Date: Tue, 10 May 2016 08:55:57 -0700 From: John Baldwin <jhb@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Hans Petter Selasky <hselasky@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm Message-ID: <4312956.Tckd6PoFKf@ralph.baldwin.cx> In-Reply-To: <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org> References: <201605101139.u4ABdaTL098171@repo.freebsd.org> <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, May 10, 2016 05:06:08 PM Hans Petter Selasky wrote: > On 05/10/16 13:39, Hans Petter Selasky wrote: > > Author: hselasky > > Date: Tue May 10 11:39:36 2016 > > New Revision: 299363 > > URL: https://svnweb.freebsd.org/changeset/base/299363 > > > > Log: > > Use function macros when possible to avoid stray substitutions. > > > > MFC after: 1 week > > Sponsored by: Mellanox Technologies > > > > FYI > > This change accidentially broke LINT and I have a patch waiting for > review from the Chelsio guys that will fix LINT and WITH_OFED=YES again. > Will hopefully be fixed shortly. Is the reason for the change to avoid accepting the wrong number of arguments (e.g. cpu_to_be32(x, y))? Won't that still fail to compile if so? (That is, the reasoning for why you made the original change isn't clear to me from the commit.) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4312956.Tckd6PoFKf>