From owner-freebsd-hackers@FreeBSD.ORG Tue Jul 6 14:41:12 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED54916A4CE for ; Tue, 6 Jul 2004 14:41:12 +0000 (GMT) Received: from mail.FreeBSD.org.cn (dns3.freebsd.org.cn [61.129.66.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E71943D39 for ; Tue, 6 Jul 2004 14:41:11 +0000 (GMT) (envelope-from delphij@frontfree.net) Received: (qmail 8165 invoked by uid 0); 6 Jul 2004 14:39:46 -0000 Received: from unknown (HELO beastie.frontfree.net) (218.107.145.7) by mail.FreeBSD.org.cn with AES256-SHA encrypted SMTP; 6 Jul 2004 14:39:46 -0000 Received: from localhost (localhost.frontfree.net [127.0.0.1]) by beastie.frontfree.net (Postfix) with ESMTP id F2C2311F35; Tue, 6 Jul 2004 22:41:03 +0800 (CST) Received: from beastie.frontfree.net ([127.0.0.1]) by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02119-03; Tue, 6 Jul 2004 22:41:03 +0800 (CST) Received: by beastie.frontfree.net (Postfix, from userid 1001) id 389D711EFA; Tue, 6 Jul 2004 22:41:02 +0800 (CST) Date: Tue, 6 Jul 2004 22:41:02 +0800 From: Xin LI To: Dag-Erling Sm?rgrav Message-ID: <20040706144102.GA4034@frontfree.net> References: <20040625033718.GA1691@frontfree.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-GPG-key-ID/Fingerprint: 0xCAEEB8C0 / 43B8 B703 B8DD 0231 B333 DC28 39FB 93A0 CAEE B8C0 X-GPG-Public-Key: http://www.delphij.net/delphij.asc X-Operating-System: FreeBSD beastie.frontfree.net 5.2-delphij FreeBSD 5.2-delphij #80: Thu Jun 24 17:30:33 CST 2004 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386 X-URL: http://www.delphij.net X-By: delphij@beastie.frontfree.net X-Location: Beijing, China X-Virus-Scanned: by amavisd-new at frontfree.net cc: hackers@FreeBSD.org cc: doc@FreeBSD.org Subject: About rules on style changes [Was: Re: Preliminary sys/netinet style patch] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2004 14:41:13 -0000 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Dag-Erling, (I have removed freebsd-net@ from cc list and added doc@ as the topic seemed to be more related to doc@) On Tue, Jul 06, 2004 at 01:50:34PM +0200, Dag-Erling Sm?rgrav wrote: > Xin LI writes: > > I have a patchset to remove tailing spaces, convert leading spaces > > to tabs, and removes spaces before tabs. >=20 > As a rule, we never do this except in conjunction with other changes. Hmm... Seems that I have misunderstood the committers' guide, section 10.3, which said: "Do not mix style fixes with new functionality. A style fix is any change which does not modify the functionality of the code. Mixing the changes obfuscates the functionality change when using cvs diff, which can hide any new bugs." I thought that this is not a strict discourage of style fixes. Shall we add something to clarify the rule, like this: "In order to prevent difficulties other committers will encounter when making changes or merging changes from third party, it is discouraged to do style changes when there is no functional changes over a subsystem, and please follow style(9) when committing new code, as a consistent style will ease others' work when merging your changes." Thanks. Cheers, --=20 Xin LI http://www.delphij.net/ See complete headers for GPG key and other information. --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA6rn+OfuToMruuMARAl+tAJwMRH92KFtSIOxXvYcvV8303naXbwCePMeo PTpr1778jc1P7/93X/2ht/k= =x0kj -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--