Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Nov 2008 23:51:02 +0300
From:      Boris Samorodov <bsam@ipt.ru>
To:        ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org
Cc:        Hajimu UMEMOTO <ume@FreeBSD.org>
Subject:   Re: cvs commit: ports/x11-toolkits/linux-gtk2 Makefile
Message-ID:  <35822953@bs1.sp34.ru>
In-Reply-To: <20081128165724.23DC310656D3@hub.freebsd.org> (Hajimu UMEMOTO's message of "Fri\, 28 Nov 2008 16\:57\:24 %2B0000 \(UTC\)")
References:  <20081128165724.23DC310656D3@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hajimu UMEMOTO <ume@FreeBSD.org> writes:

> ume         2008-11-28 16:57:09 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     x11-toolkits/linux-gtk2 Makefile 
>   Log:
>   linux_base-(fc6|f7|f8) have glib2 by itself.  Don't depend upon
>   linux-glib2 when OVERRIDE_LINUX_BASE_PORT is set to them.
>   
>   Revision  Changes    Path
>   1.24      +7 -2      ports/x11-toolkits/linux-gtk2/Makefile
> _______________________________________________
> cvs-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-all
> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
>
>
> Index: ports/x11-toolkits/linux-gtk2/Makefile
> diff -u ports/x11-toolkits/linux-gtk2/Makefile:1.23 ports/x11-toolkits/linux-gtk2/Makefile:1.24
> --- ports/x11-toolkits/linux-gtk2/Makefile:1.23	Sat Apr 19 17:55:30 2008
> +++ ports/x11-toolkits/linux-gtk2/Makefile	Fri Nov 28 16:57:09 2008
> @@ -16,8 +16,13 @@
>  
>  # these libraries are required by gtk-query-immodules-2.0 or
>  # gdk-pixbuf-query-loaders
> -RUN_DEPENDS+=	${LINUXBASE}/usr/lib/libglib-2.0.so.0:${PORTSDIR}/devel/linux-glib2 \
> -		${LINUXBASE}/usr/lib/libatk-1.0.so.0:${PORTSDIR}/accessibility/linux-atk \
> +.if !defined(OVERRIDE_LINUX_BASE_PORT) || \
> +    (${OVERRIDE_LINUX_BASE_PORT} != "fc6" && \
> +    ${OVERRIDE_LINUX_BASE_PORT} != "f7" && \
> +    ${OVERRIDE_LINUX_BASE_PORT} != "f8")
> +RUN_DEPENDS+=	${LINUXBASE}/usr/lib/libglib-2.0.so.0:${PORTSDIR}/devel/linux-glib2
> +.endif
> +RUN_DEPENDS+=	${LINUXBASE}/usr/lib/libatk-1.0.so.0:${PORTSDIR}/accessibility/linux-atk \
>  		${LINUXBASE}/usr/lib/libjpeg.so.62:${PORTSDIR}/graphics/linux-jpeg \
>  		${LINUXBASE}/usr/lib/libpng12.so.0:${PORTSDIR}/graphics/linux-png \
>  		${LINUXBASE}/usr/lib/libtiff.so.3:${PORTSDIR}/graphics/linux-tiff \

Thanks for your work at linux ports. There are some more linux ports
that depends upon linux-glib2.

BTW, I have patches for imho a better approach here: integrate
linux-glib2 port into linux_base-fc4 and remove all dependencies
upon linux-glib2. Those patches are awaiting for the ports tree
to be released.

BTW2, it will be good to give us a chance to review your patches
at freebsd-emulation@ ML.

Once again, thanks for your work.


WBR
-- 
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD committer, http://www.FreeBSD.org The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35822953>