Date: Thu, 18 Jul 2019 21:41:15 +0000 From: Brooks Davis <brooks@freebsd.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350116 - head/lib/libc/gen Message-ID: <20190718214115.GA42117@spindle.one-eyed-alien.net> In-Reply-To: <201907182133.x6ILXu4k026793@repo.freebsd.org> References: <201907182133.x6ILXu4k026793@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 18, 2019 at 09:33:56PM +0000, Brooks Davis wrote: > Author: brooks > Date: Thu Jul 18 21:33:55 2019 > New Revision: 350116 > URL: https://svnweb.freebsd.org/changeset/base/350116 >=20 > Log: > Document that setmode(3) is not thread safe. > =20 > In some circumstances, setmode(3) may call umask(2) twice to retrieve > the current mode and then restore it. Between calls, the process will > have a umask of 0. This race isn't especially serious, since it only occurs when security.bsd.unprivileged_proc_debug=3D0, but it's probably something to fix. The easiest solution would probably be to implement a getumask() syscall. -- Brooks --W/nzBZO5zC0uMSeA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJdMOd6AAoJEKzQXbSebgfARCkIAJ1llteqB1g0WemVZ9X9Sv72 6Nf7wxnTrqtXNrGqyWigDpM1ftyfsLUjvbKtN+oOIuVa3a3FQjkqTEHBpCKPrh8h XIV8v/aXr5nS+xnmd6VT7r0FLnkiKap4R3pZZ2ifcQ7lGcFUB0vU9oHcVtNt+GeL EtD8sF9m8D1MgxR6FtcoEgt2oBMECTdnZDTvjFOX3Xs44Z2qmqZR4n1EVNyTEryf QQmLXoDli6nO4QHPB/qTWfvH1scCV360vv+FQcs+huSWRW7w4hHT8j5G8MHy2pYj 9ATAHX8Q7ynQi6y38e3pREahL1r3A2QZK2F1KeVaTrlG2iq7+porGE8JqH9XVOk= =Vk+s -----END PGP SIGNATURE----- --W/nzBZO5zC0uMSeA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190718214115.GA42117>