From owner-freebsd-bugs@FreeBSD.ORG  Wed Jun 25 07:30:23 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F3DEF106566C;
	Wed, 25 Jun 2008 07:30:22 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net
	[66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id A52598FC19;
	Wed, 25 Jun 2008 07:30:22 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.128] (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id m5P6qetv085420;
	Tue, 24 Jun 2008 23:52:40 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4861EB38.6080807@freebsd.org>
Date: Tue, 24 Jun 2008 23:52:40 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: gavin@freebsd.org
References: <200806240708.m5O78Kxn088155@freefall.freebsd.org>
In-Reply-To: <200806240708.m5O78Kxn088155@freefall.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-bugs@freebsd.org
Subject: Re: bin/124915: bsdtar(1) creates files with bogus access times
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jun 2008 07:30:23 -0000

Ouch.  Yep, plain tar format doesn't store an atime,
so the atime value for the entry gets extracted as zero
and the archive_extract() routine ends up restoring
the file atime as zero.

There's a couple of ways this might be fixed.  I'm
not sure offhand whether it's better to explicitly
set the atime to match mtime or to the current time.