From owner-freebsd-git@freebsd.org Fri Jan 1 00:03:52 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A35634D5900 for ; Fri, 1 Jan 2021 00:03:52 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4D6QGw3BQ8z4Z7T for ; Fri, 1 Jan 2021 00:03:52 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 6D3D64D5883; Fri, 1 Jan 2021 00:03:52 +0000 (UTC) Delivered-To: git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6CF9A4D57D4 for ; Fri, 1 Jan 2021 00:03:52 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D6QGw2ddjz4ZTR; Fri, 1 Jan 2021 00:03:52 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f42.google.com with SMTP id o6so18195132iob.10; Thu, 31 Dec 2020 16:03:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fNz49oSEcI/fZApDp4vVNb1dxdmQshNWX7dmS9ffdnk=; b=KS8iy2GjfyOOtMfcLP9rYPNQN47YJiePTHu9bt/CaEGMgMYilyhX1em78lhcyINXs9 A5wFSSYNlkNvNyMsqKZ0jZm8LFkGhOSEbIfUdd2aA+wE1gX72SZt6HdybmE8hu9KRb1P qdxdjfNd+eAVbDZ/g7ZktpXhpnwWBJsVxZhO2Bm3Q3Vr7HzmlbrUCK7HmJVOBE5owXV9 MgmlbsdMZJdO3yRu1oZ6PHXRJLh1y7/vmVgWiM4leEI1pIyILG46/wDmR3D8/OyYHJXk bFQhfUyWQHPAK21kQfrW9mpn4a7TsVQYgEmMetvEe3M/qV8d+P+PYKjd9d/Rx8jmMrMC Oi6Q== X-Gm-Message-State: AOAM530aoi6DgGVHLjPau3PEU2U6QDVFQU3tPJyFmvEGMEpx68ISuKiJ v6I7B9fmFRpN8TCROcLKvGOkDlCjCJhBpjTJBNe7daKFLDPU6A== X-Google-Smtp-Source: ABdhPJyYijpMaRP0fVllOoVANFdWa2BTT+2ntE+E459S5SoLYFzeh01ZeWoZWfs1UGMrCZKyBI+PHfmTR3J33/T89wY= X-Received: by 2002:a6b:b5d2:: with SMTP id e201mr47584857iof.111.1609459429911; Thu, 31 Dec 2020 16:03:49 -0800 (PST) MIME-Version: 1.0 References: <2bff94da-deb9-2410-b580-441eb31c8d40@FreeBSD.org> In-Reply-To: <2bff94da-deb9-2410-b580-441eb31c8d40@FreeBSD.org> From: Ed Maste Date: Thu, 31 Dec 2020 19:03:37 -0500 Message-ID: Subject: Re: Thoughts on git commit mail To: John Baldwin Cc: Li-Wen Hsu , git@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D6QGw2ddjz4ZTR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 00:03:52 -0000 On Thu, 31 Dec 2020 at 17:14, John Baldwin wrote: > > The mix of fields for name and date is a bit odd though. Perhaps another > alternative might be to elide the Author fields if the Author == Committer? > That would keep a lean format when when the individuals are the same. > For that suggestion, I think you would always show the two Commit fields > ("Committer" and "CommitDate") and only show "Author" and "AuthorDate" > if Author != Committer? I discussed this a bit with John on IRC, but for the benefit of the list: We expect Author == Committer will be common, and the commit date is probably the more interesting date. In addition, committer will always be someone@FreeBSD.org, so what about if we take John's suggestion for Date, and use the author name, appending (via /committer/) if it's not the author? Thus, for the example above: Author: John Baldwin (via rlibby) Date: 2020-12-31 19:56:33 +0000 This is nice and concise while conveying all useful information, IMO. This would work identically for MFCs of commits made by other committers, as well as committing changes submitted by 3rd parties.