From owner-cvs-all@FreeBSD.ORG Fri Jul 17 11:29:13 2009 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 031C6106564A; Fri, 17 Jul 2009 11:29:13 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 6CEBF8FC08; Fri, 17 Jul 2009 11:29:12 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (adsl145-161.kln.forthnet.gr [195.74.244.161]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-9) with ESMTP id n6HBSub7023102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 17 Jul 2009 14:29:03 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.3/8.14.3) with ESMTP id n6HBStLf006813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 17 Jul 2009 14:28:55 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.3/8.14.3/Submit) id n6HBSsn3006812; Fri, 17 Jul 2009 14:28:54 +0300 (EEST) (envelope-from keramida@freebsd.org) From: Giorgos Keramidas To: Adam McDougall References: <200907091315.n69DF7jL036835@repoman.freebsd.org> <20090709140850.GZ86673@droso.net> <87iqi2x7st.fsf@kobe.laptop> <20090709143714.GA86673@droso.net> <4A5F6603.3010401@egr.msu.edu> Date: Fri, 17 Jul 2009 14:28:46 +0300 In-Reply-To: <4A5F6603.3010401@egr.msu.edu> (Adam McDougall's message of "Thu, 16 Jul 2009 13:40:19 -0400") Message-ID: <87fxcvim4x.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Hellug-MailScanner-ID: n6HBSub7023102 X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-4.399, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: cvs-ports@freebsd.org, Erwin Lansing , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/mail/postfix/files patch-src::util::sys_defs.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2009 11:29:13 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 16 Jul 2009 13:40:19 -0400, Adam McDougall w= rote: >> keramida 2009-07-09 13:15:07 UTC >> >> FreeBSD ports repository (doc committer) >> >> Added files: >> mail/postfix/files patch-src::util::sys_defs.h >> Log: >> Patch the src/util/sys_defs.h file of Postfix to fix the build on >> FreeBSD-8.0 after the new closefrom() system call was added. >> >> PR: ports/136459 >> Submitted by: Eygene Ryabinkin >> Approved by: erwin (portmgr), Sahil Tandon (maintainer) > I think this is now needed on 7-stable as well as of svn 195694 (702104): ... > /usr/include/unistd.h:329: error: conflicting types for 'closefrom' > ./sys_defs.h:1404: error: previous declaration of 'closefrom' was here > *** Error code 1 > > Stop in /var/tmp/ports/usr/ports/mail/postfix/work/postfix-2.6.2/src/util. > *** Error code 1 Yes, we have to use the same for stable/7 after change 195694: % r195694 | jhb | 2009-07-14 22:48:31 +0300 (Tue, 14 Jul 2009) | 4 lines % % MFC: Add a new 'void closefrom(int lowfd)' system call. When called, it % closes any open file descriptors >=3D 'lowfd'. Bump __FreeBSD_version to % 702104. Erwin, does the following look ok for ports/mail/postfix? %%% Index: files/patch-src::util::sys_defs.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/mail/postfix/files/patch-src::util::sys_defs.h,v retrieving revision 1.4 diff -u -r1.4 patch-src::util::sys_defs.h =2D-- files/patch-src::util::sys_defs.h 9 Jul 2009 13:15:07 -0000 1.4 +++ files/patch-src::util::sys_defs.h 17 Jul 2009 11:27:47 -0000 @@ -1,9 +1,13 @@ =2D--- src/util/sys_defs.h.orig 2009-07-08 13:38:52.000000000 +0400 =2D+++ src/util/sys_defs.h 2009-07-08 13:46:41.000000000 +0400 =2D@@ -110,6 +110,15 @@ +--- src/util/sys_defs.h.orig 2009-05-11 03:45:27.000000000 +0300 ++++ src/util/sys_defs.h 2009-07-17 14:27:26.471309371 +0300 +@@ -110,6 +110,19 @@ #define HAS_DUPLEX_PIPE /* 4.1 breaks with kqueue(2) */ #endif =20=20 ++#if __FreeBSD_version >=3D 702104 ++#define HAS_CLOSEFROM /* 7.x has closefrom() now */ ++#endif ++ +#if __FreeBSD_version >=3D 800100 /* + * Actually, slightly before, + * but we can't say precisely %%% --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkpgYHYACgkQ1g+UGjGGA7Y/TwCdF24P1uUztQUlqdLOaM2+gh6V UmcAoKP0zc5iKtGmapGZw7JR4HWY3Wgr =8BeK -----END PGP SIGNATURE----- --=-=-=--