Date: Tue, 20 Jan 2015 08:28:46 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r377495 - head/textproc/py-pygments Message-ID: <20150120082846.GA84520@FreeBSD.org> In-Reply-To: <54BE0F14.5030304@marino.st> References: <201501200412.t0K4CVOj052563@svn.freebsd.org> <20150120081220.GB57237@FreeBSD.org> <54BE0F14.5030304@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 20, 2015 at 09:17:24AM +0100, John Marino wrote: > On 1/20/2015 09:12, Alexey Dokuchaev wrote: > > On Tue, Jan 20, 2015 at 04:12:31AM +0000, Adam Weinberger wrote: > >> New Revision: 377495 > >> URL: https://svnweb.freebsd.org/changeset/ports/377495 > >> QAT: https://qat.redports.org/buildarchive/r377495/ > >> > >> Log: > >> Update to 2.0.1. > >> > >> [...] > >> -OPTIONS_DEFINE= DOCS > >> - > > > > Commit log does not mention this change, was it intended? If so, what > > was the reason behind it? > > The line is redundant -- it's presence or absence doesn't change > anything. In this case it would be nice to mention something like "remove DOCS option because the port no longer installs documentation" in the log. > You know how I write commit messages and thus know I agree it > could have been mentioned given how short the message was (if it were 1 > of 100 changes I wouldn't have mentioned it myself). Yes, I know. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150120082846.GA84520>