Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Mar 2007 19:37:55 +0700
From:      Eugene Grosbein <eugen@kuzbass.ru>
To:        Andre Oppermann <andre@freebsd.org>
Cc:        freebsd-net@freebsd.org, freebsd-bugs@freebsd.org, Harti Brandt <harti@freebsd.org>
Subject:   Re: kern/110720: [net] [patch] support for interface descriptions
Message-ID:  <20070324123754.GA80483@svzserv.kemerovo.su>
In-Reply-To: <4604FDD4.2080805@freebsd.org>
References:  <200703231844.l2NIiCsa089542@freefall.freebsd.org> <20070324102948.Q58113@knop-beagle.kn.op.dlr.de> <4604FDD4.2080805@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 24, 2007 at 11:30:44AM +0100, Andre Oppermann wrote:

> Harti Brandt wrote:
> >Nice feature, although it would be nice to align the maximum length with 
> >IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more 
> >naturally fits into struct if_data (see net/if.h) given the comment for 
> >that struct:
> >
> >/*
> > * Structure describing information about an interface
> > * which may be of interest to management entities.
> > */
> 
> The string array should most likely not be part of struct ifnet as that
> would bloat it quite a bit.  If it is in there it should be at the end
> of the struct to avoid cache line busting effects.

Also vote for this. And is it possible to make it a pointer instead
of array? The bloat would be minimal for system with tons of interfaces,
think about large pptp or pppoe server or similar that never would
utilize arrays.

Eugene Grosbein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070324123754.GA80483>