From owner-freebsd-bugs@FreeBSD.ORG  Sat Mar 24 12:54:06 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@freebsd.org
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 54D1416A485;
	Sat, 24 Mar 2007 12:54:06 +0000 (UTC)
	(envelope-from eugen@www.svzserv.kemerovo.su)
Received: from www.svzserv.kemerovo.su (www.svzserv.kemerovo.su
	[213.184.65.80])
	by mx1.freebsd.org (Postfix) with ESMTP id A49FB13C4BE;
	Sat, 24 Mar 2007 12:54:05 +0000 (UTC)
	(envelope-from eugen@www.svzserv.kemerovo.su)
Received: from www.svzserv.kemerovo.su (eugen@localhost [127.0.0.1])
	by www.svzserv.kemerovo.su (8.13.8/8.13.8) with ESMTP id l2OCbtfW024212;
	Sat, 24 Mar 2007 19:37:55 +0700 (KRAT)
	(envelope-from eugen@www.svzserv.kemerovo.su)
Received: (from eugen@localhost)
	by www.svzserv.kemerovo.su (8.13.8/8.13.8/Submit) id l2OCbtdq024211;
	Sat, 24 Mar 2007 19:37:55 +0700 (KRAT) (envelope-from eugen)
Date: Sat, 24 Mar 2007 19:37:55 +0700
From: Eugene Grosbein <eugen@kuzbass.ru>
To: Andre Oppermann <andre@freebsd.org>
Message-ID: <20070324123754.GA80483@svzserv.kemerovo.su>
References: <200703231844.l2NIiCsa089542@freefall.freebsd.org>
	<20070324102948.Q58113@knop-beagle.kn.op.dlr.de>
	<4604FDD4.2080805@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4604FDD4.2080805@freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-net@freebsd.org, freebsd-bugs@freebsd.org,
	Harti Brandt <harti@freebsd.org>
Subject: Re: kern/110720: [net] [patch] support for interface descriptions
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Mar 2007 12:54:06 -0000

On Sat, Mar 24, 2007 at 11:30:44AM +0100, Andre Oppermann wrote:

> Harti Brandt wrote:
> >Nice feature, although it would be nice to align the maximum length with 
> >IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more 
> >naturally fits into struct if_data (see net/if.h) given the comment for 
> >that struct:
> >
> >/*
> > * Structure describing information about an interface
> > * which may be of interest to management entities.
> > */
> 
> The string array should most likely not be part of struct ifnet as that
> would bloat it quite a bit.  If it is in there it should be at the end
> of the struct to avoid cache line busting effects.

Also vote for this. And is it possible to make it a pointer instead
of array? The bloat would be minimal for system with tons of interfaces,
think about large pptp or pppoe server or similar that never would
utilize arrays.

Eugene Grosbein