From owner-cvs-all Thu Jan 17 8:49:43 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id CE79C37B41D; Thu, 17 Jan 2002 08:49:24 -0800 (PST) Received: from bmah.dyndns.org ([12.233.149.189]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020117164924.RGNM10199.rwcrmhc53.attbi.com@bmah.dyndns.org>; Thu, 17 Jan 2002 16:49:24 +0000 Received: (from bmah@localhost) by bmah.dyndns.org (8.11.6/8.11.6) id g0HGnOD23179; Thu, 17 Jan 2002 08:49:24 -0800 (PST) (envelope-from bmah) Message-Id: <200201171649.g0HGnOD23179@bmah.dyndns.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Warner Losh Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, oberman@es.net Subject: Re: cvs commit: src/sys/dev/sio sio.c In-reply-to: <200201171616.g0HGGqn13750@freefall.freebsd.org> References: <200201171616.g0HGGqn13750@freefall.freebsd.org> Comments: In-reply-to Warner Losh message dated "Thu, 17 Jan 2002 08:16:52 -0800." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.org X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 17 Jan 2002 08:49:24 -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG If memory serves me right, Warner Losh wrote: > imp 2002/01/17 08:16:52 PST > > Modified files: > sys/dev/sio sio.c > Log: > While I'm not sure that I like the wording of the BIOS message in the > previous commit, it should always print due to lack of {} around the > second line in the if statement. The message should likely say > something more like "There's no hardware responding at this IRQ. > Device not present (or disbaled)," but that is too long. Pointy hat to: bmah I even tested this patch (I bet nobody's going to believe that one!), and somehow missed the output in dmesg. :-( > We generally > don't give elementary advise in device driver messages anyway. Be > that as it may, the problem with it printing all the time should be > corrected. It's a support issue. I don't object real strongly to backing out the "port may be disabled" message but the way that the sio probe claimed a disabled port was really an 8250 was pretty bogus and has bitten a bunch of people (me included). So I think that some form of the second hunk of the patch should stay in. Bruce. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message