From owner-cvs-all@FreeBSD.ORG  Wed Dec 27 13:15:35 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C443016A407;
	Wed, 27 Dec 2006 13:15:35 +0000 (UTC) (envelope-from yar@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id B5C6D13C474;
	Wed, 27 Dec 2006 13:15:35 +0000 (UTC) (envelope-from yar@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kBRDFZia012787;
	Wed, 27 Dec 2006 13:15:35 GMT (envelope-from yar@repoman.freebsd.org)
Received: (from yar@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kBRDFZYI012782;
	Wed, 27 Dec 2006 13:15:35 GMT (envelope-from yar)
Message-Id: <200612271315.kBRDFZYI012782@repoman.freebsd.org>
From: Yar Tikhiy <yar@FreeBSD.org>
Date: Wed, 27 Dec 2006 13:15:34 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/etc rc.subr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Dec 2006 13:15:35 -0000

yar         2006-12-27 13:15:34 UTC

  FreeBSD src repository

  Modified files:
    etc                  rc.subr 
  Log:
  MFp4:
  
  Implement the checks for required_* objects as two functions, one
  to be run before precmd and the other after it.  They get the current
  rc command as an argument so they can choose what requirement tests
  to perform.  As of now, only "start" needs such tests.
  
  Implement a new requirement variable, required_modules.  It can
  list kernel modules that need to be loaded after start_precmd
  indicated success.  Each name in the list can be just "file", or
  "file:module", or "file~regex".  This will allow us to remove a lot
  of duplicated code from rc.d scripts.
  
  Perform the checks not only for the default start method, but for
  any method.  This allows for more flexibility and fixes a few rc.d
  scripts (namely newsyslog, pf, sendmail) that rely on a required_*
  variable while providing a non-default start method.
  
  To be able to call the new check_required* functions naturally,
  remove lots of crufty duplicated code pieces from run_rc_command
  and replace each of them by a call to the helper function providing
  a single corrected instance of the respective code snippet.  Now
  run_rc_command isn't as scary as it used to be, and it even appears
  to have quite a nice logic that was obscured by the old crufty code.
  
  In the default handler for restart, run start from a subshell to
  protect global varibles, e.g., _postcmd, from modification by the
  start handler.  This enables using restart_postcmd. [x]
  
  PR:             conf/98734 [x]
  Submitted by:   Rick van der Zwet <rick@wzoeterwoude.net> [x]
  Reviewed by:    freebsd-rc (silence for an older version)
  MFC after:      1 month
  
  Revision  Changes    Path
  1.72      +198 -146  src/etc/rc.subr