From owner-p4-projects@FreeBSD.ORG  Wed Feb 20 19:10:20 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 607C016A46E; Wed, 20 Feb 2008 19:10:20 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 25B6616A46B
	for <perforce@freebsd.org>; Wed, 20 Feb 2008 19:10:20 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C62B13C46B
	for <perforce@freebsd.org>; Wed, 20 Feb 2008 19:10:20 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m1KJAJNT084585
	for <perforce@freebsd.org>; Wed, 20 Feb 2008 19:10:19 GMT
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m1KJAJqJ084582
	for perforce@freebsd.org; Wed, 20 Feb 2008 19:10:19 GMT
	(envelope-from sam@freebsd.org)
Date: Wed, 20 Feb 2008 19:10:19 GMT
Message-Id: <200802201910.m1KJAJqJ084582@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 135829 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2008 19:10:20 -0000

http://perforce.freebsd.org/chv.cgi?CH=135829

Change 135829 by sam@sam_ebb on 2008/02/20 19:10:14

	guard against someone bumping the # beacon buffers too high
	and leave an explanation why it's not a good idea

Affected files ...

.. //depot/projects/vap/sys/dev/ath/if_ath.c#34 edit

Differences ...

==== //depot/projects/vap/sys/dev/ath/if_ath.c#34 (text+ko) ====

@@ -84,6 +84,22 @@
 #include <dev/ath/ath_tx99/ath_tx99.h>
 #endif
 
+/*
+ * ATH_BCBUF determines the number of vap's that can transmit
+ * beacons and also (currently) the number of vap's that can
+ * have unique mac addresses/bssid.  When staggering beacons
+ * 4 is probably a good max as otherwise the beacons become
+ * very closely spaced and there is limited time for cab q traffic
+ * to go out.  You can burst beacons instead but that is not good
+ * for stations in power save and at some point you really want
+ * another radio (and channel).
+ *
+ * The limit on the number of mac addresses is tied to our use of
+ * the U/L bit and tracking addresses in a byte; it would be
+ * worthwhile to allow more for applications like proxy sta.
+ */
+CTASSERT(ATH_BCBUF <= 8);
+
 /* unaligned little endian access */
 #define LE_READ_2(p)							\
 	((u_int16_t)							\