From owner-cvs-ports@FreeBSD.ORG  Thu Dec  9 21:46:14 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4DE9016A4CE; Thu,  9 Dec 2004 21:46:14 +0000 (GMT)
Received: from imf17aec.mail.bellsouth.net (imf17aec.mail.bellsouth.net
	[205.152.59.65])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 57B1D43D53; Thu,  9 Dec 2004 21:46:13 +0000 (GMT)
	(envelope-from ahze@ahze.net)
Received: from [192.168.1.5] ([68.209.163.3])
	by imf17aec.mail.bellsouth.netESMTP
	<20041209214612.FHCW1994.imf17aec.mail.bellsouth.net@[192.168.1.5]>;
	Thu, 9 Dec 2004 16:46:12 -0500
In-Reply-To: <20041209214821.GA89551@xor.obsecurity.org>
References: <200412091921.iB9JL4F7081024@repoman.freebsd.org>
	<20041209212909.GA89159@xor.obsecurity.org>
	<E81CBD9D-4A29-11D9-80E0-000A958C81C6@ahze.net>
	<20041209214821.GA89551@xor.obsecurity.org>
Mime-Version: 1.0 (Apple Message framework v619)
Content-Type: multipart/signed; protocol="application/pgp-signature";
	micalg=pgp-sha1; boundary="Apple-Mail-2--232484121"
Message-Id: <BB806AFE-4A2B-11D9-80E0-000A958C81C6@ahze.net>
Content-Transfer-Encoding: 7bit
From: Michael Johnson <ahze@ahze.net>
Date: Thu, 9 Dec 2004 16:46:07 -0500
To: Kris Kennaway <kris@obsecurity.org>
X-Pgp-Agent: GPGMail 1.0.2
X-Mailer: Apple Mail (2.619)
cc: cvs-ports@FreeBSD.org
cc: Michael Johnson <ahze@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/math/fftw3 Makefile ports/math/fftw3/files
	patch-alloc.c
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2004 21:46:14 -0000


--Apple-Mail-2--232484121
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII; format=flowed


On Dec 9, 2004, at 4:48 PM, Kris Kennaway wrote:

> On Thu, Dec 09, 2004 at 04:33:03PM -0500, Michael Johnson wrote:
>>
>> On Dec 9, 2004, at 4:29 PM, Kris Kennaway wrote:
>>
>>> On Thu, Dec 09, 2004 at 07:21:04PM +0000, Michael Johnson wrote:
>>>> ahze        2004-12-09 19:21:04 UTC
>>>>
>>>>  FreeBSD ports repository
>>>>
>>>>  Modified files:
>>>>    math/fftw3           Makefile
>>>>    math/fftw3/files     patch-alloc.c
>>>>  Log:
>>>>  - Add note about WITH_OPTIMIZED_ATHLON will fall back to 3dNow if
>>>> you don't have
>>>>    a Athlon
>>>
>>> Why not just use the CPU feature list from <bsd.cpu.mk>, so it
>>> automatically DTRT when CPUTYPE is set?
>>
>>
>> Should I do it like...
>>
>> .if ${CPUTYE}=="athlon" || ${CPUTYPE}=="athlon-xp" ||
>> ${CPUTYPE}=="k6-3" || ${CPUTYPE}=="k6-2" ... etc
>> ..code...
>> .endif
>>
>> ??
>
> No, see e.g. mpg123

ahh, thanks

Should I remove the OPTION and always use that if the cpu has 3dnow or 
still give an option to do it?
>
> Kris

--Apple-Mail-2--232484121
content-type: application/pgp-signature; x-mac-type=70674453;
	name=PGP.sig
content-description: This is a digitally signed message part
content-disposition: inline; filename=PGP.sig
content-transfer-encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iD8DBQFBuMefn4uqfTwEb9YRAiekAJ46GTj0NpB1zrdAZCXpV9jrr9hwUgCePRYG
6ISa8TpxBgOemHRFm6iIcXg=
=DPM2
-----END PGP SIGNATURE-----

--Apple-Mail-2--232484121--