From owner-cvs-all Thu Jun 29 2:51:59 2000 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 879E137B540; Thu, 29 Jun 2000 02:51:54 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (from jhb@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id CAA16896; Thu, 29 Jun 2000 02:51:54 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-Id: <200006290951.CAA16896@freefall.freebsd.org> From: John Baldwin Date: Thu, 29 Jun 2000 02:51:54 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/boot/i386/btx/btx btx.s X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG jhb 2000/06/29 02:51:54 PDT Modified files: sys/boot/i386/btx/btx btx.s Log: Note that the cleaning up and reordering in revision 1.19 actually fixed a nasty bug. The comparison to tset for an instruciton with the $0xf prefix should have jumped down to the next non-prefix instruction test. Instead, it jumped down to the next instruction test, which happened to be prefixed instruction test. This test assumed that the earlier test had succeeded, thus in some rare cases, this test would actually succeed, and we would actually attempt to emulate a RDMSR instruction instead of the instruction we were supposed to be emulating. Since %ecx usually did not contain a valid MSR index at the time of the trap, this usually resulted in a #GP due to an invalid MSR address and a lovely BTX fault when one tried to boot the machine. Noticed by: unfurl and others Revision Changes Path 1.21 +1 -1 src/sys/boot/i386/btx/btx/btx.s To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message