Date: Mon, 29 Oct 2007 00:13:06 +0300 From: Andrey Chernov <ache@nagual.pp.ru> To: Rong-en Fan <grafan@gmail.com> Cc: Scott Long <scottl@samsco.org>, src-committers@FreeBSD.ORG, d@delphij.net, John Baldwin <jhb@FreeBSD.ORG>, cvs-src@FreeBSD.ORG, Robert Watson <rwatson@FreeBSD.ORG>, imp@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/locale utf8.c Message-ID: <20071028211306.GA91223@nagual.pp.ru> In-Reply-To: <6eb82e0710280154h68393dcag4e9ba4ac4c219065@mail.gmail.com> References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <6eb82e0710270130o5557efew95f62aef8035d209@mail.gmail.com> <20071027092213.GA53271@nagual.pp.ru> <6eb82e0710280154h68393dcag4e9ba4ac4c219065@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 28, 2007 at 04:54:52PM +0800, Rong-en Fan wrote: > > As a small improvement, we can skip __isctype() from this list too and > > just hardcode 128 there, i.e.: return (_c < 0 || _c >= 128) ... > > since default locale never define anything above 128. > > Thank you. A new patch is available at > > http://people.freebsd.org/~rafan/ctype-abi-fix-6-try2.diff Looks OK. Please don't forget MFC __isctype changes to 7x too. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071028211306.GA91223>