From owner-freebsd-net@FreeBSD.ORG  Tue Jan 27 19:50:27 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8FE0DA53;
 Tue, 27 Jan 2015 19:50:27 +0000 (UTC)
Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 788D0C74;
 Tue, 27 Jan 2015 19:50:27 +0000 (UTC)
Received: from localhost (unknown [10.1.1.3])
 (Authenticated sender: hiren@strugglingcoder.info)
 by mail.strugglingcoder.info (Postfix) with ESMTPSA id 254B6CB360;
 Tue, 27 Jan 2015 11:50:27 -0800 (PST)
Date: Tue, 27 Jan 2015 11:50:27 -0800
From: hiren panchasara <hiren@strugglingcoder.info>
To: Sreekanth Rupavatharam <rupavath@juniper.net>
Subject: Re: Double cleanup in igb_attach
Message-ID: <20150127195027.GB63990@strugglingcoder.info>
References: <D0EC151C.1A7B1%rupavath@juniper.net>
 <20150127192814.GA63990@strugglingcoder.info>
 <D0ED284D.1A867%rupavath@juniper.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+"
Content-Disposition: inline
In-Reply-To: <D0ED284D.1A867%rupavath@juniper.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "jfv@freebsd.org" <jfv@freebsd.org>,
 "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jan 2015 19:50:27 -0000


--NMuMz9nt05w80d4+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 27, 2015 at 07:36:17PM +0000, Sreekanth Rupavatharam wrote:
> >
> >Seems reasonable to me at the first glance.
> >
> >We need to call IGB_CORE_LOCK_DESTROY(adapter) before returning though.
> >
> Not necessary. igb_detach does that.

Bah, I read that call inside detach as UNLOCK. Yeah, you are right.=20

cheers,
Hiren

--NMuMz9nt05w80d4+
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQF8BAEBCgBmBQJUx+wCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4
QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lrFQIAKY7yW//68Wa3mw7vp4nH4p9
BqtJEe57mOnCC5jwC1U4V+y8Mpivc/ZG1VwJ7uvmVVK5IjLwp8xWqgh4ub8/vXpb
qTQe99g3j/1kNjNuklGtuaB2sWTZ0qYTnQA8I645Ns2CrTMEuJ6B1r5JnKNYAlEE
8J/f8gfraCjtKFT/1CXedxiXodvNHcvv4s/4D6xJiPuYMFFz0wIN63McVGJK0027
bA35fkIm9TuCgpFZaIpPAe48R7VVni3mnWGnw5SGBwp6G3JQQLb8ZxnB4VjjLk3Q
jvjJLdVc3+e1CWSCV4XauqQsbmTCbRbym9INB4KhvbFIVYoL+GyFAJtBriYObtw=
=065L
-----END PGP SIGNATURE-----

--NMuMz9nt05w80d4+--