Date: Sun, 14 Mar 2010 21:56:28 +0100 From: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= <decke@bluelife.at> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Wesley Shields <wxs@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Aw: Re: Aw: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in Message-ID: <1268600188.8515.3.camel@Nokia-N900-42-11> In-Reply-To: <4B9D45C4.3090608@FreeBSD.org> References: <201003140407.o2E47fhJ063684@repoman.freebsd.org> <4B9C6C9E.3070902@FreeBSD.org> <1268589378.8345.2.camel@Nokia-N900-42-11> <4B9D45C4.3090608@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Urspr=C3=BCngliche Mitteilung ----- > On 03/14/10 10:56, Bernhard Fr=C3=B6hlich wrote: > > ----- Urspr=C3=BCngliche Mitteilung ----- > > > On 03/13/10 20:07, Wesley Shields wrote: > > > > wxs=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2010-03-14 04:07:41 UTC > > > > > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 FreeBSD ports repository > > > > > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Modified files: > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 www/redmine= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Makefile > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Added files: > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 www/redmine/= files=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 redmine.in > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Log: > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Add RC script. > > > >=C2=A0 =C2=A0 =C2=A0 > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/144299 > > > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D144299=C2=A0 =C2=A0 = =C2=A0 Submitted by:=C2=A0 =C2=A0 > > > > Bernhard Froehlich <decke@bluelife.at> (maintainer)=C2=A0 =C2=A0 > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Revision=C2=A0 Changes=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Path > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 1.8=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +6 -0=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/www/redmine/Makefile > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 1.1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +32 -0=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 ports/www/redmine/files/redmine.in (new) > > > > > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.di= ff?&r1=3D1.7&r2=3D1.8&f=3Dh > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmi= ne.in > > > > > > There are several problems with this script. > > > > Thanks for your comment. I will have a look at the issues in the next f= ew days. > > > > > 1. The REQUIRE line needs to be changed to LOGIN. This is preferred f= or > > > all local scripts, but mandatory for those which run with a non-root > > > [ug]id (which this one does). > > > > > > 2. Instead of command=3D%%RUBY_NAME%% it's likely you want to use > > > command_interpreter instead. Does the stop command work with this scr= ipt > > > as it is currently? > > > > Yes it does work fine. I use it since a few months. The binary that is = shown > > with top is ruby18 and RUBY_NAME is exactly that. > > My concern would be that for users with other versions of ruby installed > it might not work, but if what you have works now (and no one more > knowledgeable about ruby speaks up) then that's fine. > > > > 3. _flags should not be included in command_args, it will result in t= hem > > > being included twice. > > > > Oh did not know that the flags are automatically append to command_args= . I > > will check and remove this then. > > Ok. > > > > 4. Are all of the options included in _flags actually things that a u= ser > > > might wish to twiddle? Should some of them be in command_args instead= ? > > > > Yes they are but the user should have no reason to change user and grou= p so > > this could be moved to command_args. > > > > > 5. The pidfile location looks dubious to me, but I'm not sure if putt= ing > > > pid files in WWWDIR has somehow become routine? > > > > That is a bigger disussion because redmine is designed to work complete= ly > > inside of his home directory and that includes scripts, pidfiles, tmp a= nd > > everything else. I have already looked at spliting that up but decided = against > > it because it would be a bad hack. > > I'm not willing to tilt at that windmill, so if anyone cares about this, > speak up. :) > > > > 6. And finally a minor issue, %%RC_SUBR%% should just be /etc/rc.subr= . > > > I'll be making that change for all ports once the ports freeze is ove= r, > > > so no reason not to do it now. > > > > Did not know that either. When thinking about that issues it would have= been > > good to have a few good examples or a documentation. Does that probably > > already exist and i just haven't found it? > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scri= pts.html > > > Thanks for your comments and i will also have a look at my other starts= cripts > > if they have the same problems. > > Ok. Meanwhile I've attached a patch for the current version with the > non-controversial changes I mentioned above, and also Adding a > $FreeBSD$, and using %%WWWDIR%% throughout instead of creating a > variable for it. The SUB routine for the ports can handle as many > substitutions of the same value as you need it to, and this way is > (slightly) more efficient, and (slightly) less confusing. With your > permission I'll commit this fix since Wesley is going to be traveling. Thanks for the patch! At the moment i do not have a possibility to double c= heck them but the changes look good to me so please feel free to commit the= m. -- Bernhard Fr=C3=B6hlich=20 http://www.bluelife.at/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1268600188.8515.3.camel>