From owner-cvs-all@FreeBSD.ORG Sun Mar 14 20:57:07 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE6F2106566B; Sun, 14 Mar 2010 20:57:07 +0000 (UTC) (envelope-from decke@bluelife.at) Received: from mail.itac.at (mail.itac.at [91.205.172.9]) by mx1.freebsd.org (Postfix) with ESMTP id 015EF8FC14; Sun, 14 Mar 2010 20:57:06 +0000 (UTC) Received: from [92.248.55.29] by mail.itac.at with esmtpa (Exim 4.63) (envelope-from ) id 1Nqurx-0005RO-IM; Sun, 14 Mar 2010 21:57:06 +0100 From: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= To: Doug Barton X-Mailer: Modest 3.1 References: <201003140407.o2E47fhJ063684@repoman.freebsd.org> <4B9C6C9E.3070902@FreeBSD.org> <1268589378.8345.2.camel@Nokia-N900-42-11> <4B9D45C4.3090608@FreeBSD.org> In-Reply-To: <4B9D45C4.3090608@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-ID: <1268600187.8515.2.camel@Nokia-N900-42-11> X-MSMail-Priority: Normal X-Priority: 3 Date: Sun, 14 Mar 2010 21:56:28 +0100 Message-Id: <1268600188.8515.3.camel@Nokia-N900-42-11> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "mail.itac.at", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: ----- Ursprüngliche Mitteilung ----- > On 03/14/10 10:56, Bernhard Fröhlich wrote: > > ----- Ursprüngliche Mitteilung ----- > > > On 03/13/10 20:07, Wesley Shields wrote: > > > > wxs               2010-03-14 04:07:41 UTC > > > > > > > >    FreeBSD ports repository > > > > > > > >    Modified files: > > > >        www/redmine                 Makefile > > > >    Added files: > > > >        www/redmine/files     redmine.in > > > >    Log: > > > >    - Add RC script. > > > >   > > > >    PR:                       ports/144299 > > > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144299   Submitted by:  > > > > Bernhard Froehlich (maintainer)  > > > >    Revision Changes     Path > > > >    1.8           +6 -0         ports/www/redmine/Makefile > > > >    1.1           +32 -0       ports/www/redmine/files/redmine.in (new) > > > > > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.diff?&r1=1.7&r2=1.8&f=h > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmine.in > > > > > > There are several problems with this script. > > > > Thanks for your comment. I will have a look at the issues in the next few days. > > > > > 1. The REQUIRE line needs to be changed to LOGIN. This is preferred for > > > all local scripts, but mandatory for those which run with a non-root > > > [ug]id (which this one does). > > > > > > 2. Instead of command=%%RUBY_NAME%% it's likely you want to use > > > command_interpreter instead. Does the stop command work with this script > > > as it is currently? > > > > Yes it does work fine. I use it since a few months. The binary that is shown > > with top is ruby18 and RUBY_NAME is exactly that. > > My concern would be that for users with other versions of ruby installed > it might not work, but if what you have works now (and no one more > knowledgeable about ruby speaks up) then [...] Content analysis details: (1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP 3.4 FH_DATE_PAST_20XX The date is grossly in the future. 0.0 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE Cc: cvs-ports@FreeBSD.org, Wesley Shields , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Aw: Re: Aw: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 20:57:08 -0000 ----- Urspr=C3=BCngliche Mitteilung ----- > On 03/14/10 10:56, Bernhard Fr=C3=B6hlich wrote: > > ----- Urspr=C3=BCngliche Mitteilung ----- > > > On 03/13/10 20:07, Wesley Shields wrote: > > > > wxs=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2010-03-14 04:07:41 UTC > > > > > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 FreeBSD ports repository > > > > > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Modified files: > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 www/redmine= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Makefile > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Added files: > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 www/redmine/= files=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 redmine.in > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Log: > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Add RC script. > > > >=C2=A0 =C2=A0 =C2=A0 > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/144299 > > > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D144299=C2=A0 =C2=A0 = =C2=A0 Submitted by:=C2=A0 =C2=A0 > > > > Bernhard Froehlich (maintainer)=C2=A0 =C2=A0 > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 Revision=C2=A0 Changes=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Path > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 1.8=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +6 -0=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/www/redmine/Makefile > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 1.1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +32 -0=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 ports/www/redmine/files/redmine.in (new) > > > > > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.di= ff?&r1=3D1.7&r2=3D1.8&f=3Dh > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmi= ne.in > > > > > > There are several problems with this script. > > > > Thanks for your comment. I will have a look at the issues in the next f= ew days. > > > > > 1. The REQUIRE line needs to be changed to LOGIN. This is preferred f= or > > > all local scripts, but mandatory for those which run with a non-root > > > [ug]id (which this one does). > > > > > > 2. Instead of command=3D%%RUBY_NAME%% it's likely you want to use > > > command_interpreter instead. Does the stop command work with this scr= ipt > > > as it is currently? > > > > Yes it does work fine. I use it since a few months. The binary that is = shown > > with top is ruby18 and RUBY_NAME is exactly that. > > My concern would be that for users with other versions of ruby installed > it might not work, but if what you have works now (and no one more > knowledgeable about ruby speaks up) then that's fine. > > > > 3. _flags should not be included in command_args, it will result in t= hem > > > being included twice. > > > > Oh did not know that the flags are automatically append to command_args= . I > > will check and remove this then. > > Ok. > > > > 4. Are all of the options included in _flags actually things that a u= ser > > > might wish to twiddle? Should some of them be in command_args instead= ? > > > > Yes they are but the user should have no reason to change user and grou= p so > > this could be moved to command_args. > > > > > 5. The pidfile location looks dubious to me, but I'm not sure if putt= ing > > > pid files in WWWDIR has somehow become routine? > > > > That is a bigger disussion because redmine is designed to work complete= ly > > inside of his home directory and that includes scripts, pidfiles, tmp a= nd > > everything else. I have already looked at spliting that up but decided = against > > it because it would be a bad hack. > > I'm not willing to tilt at that windmill, so if anyone cares about this, > speak up. :) > > > > 6. And finally a minor issue, %%RC_SUBR%% should just be /etc/rc.subr= . > > > I'll be making that change for all ports once the ports freeze is ove= r, > > > so no reason not to do it now. > > > > Did not know that either. When thinking about that issues it would have= been > > good to have a few good examples or a documentation. Does that probably > > already exist and i just haven't found it? > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scri= pts.html > > > Thanks for your comments and i will also have a look at my other starts= cripts > > if they have the same problems. > > Ok. Meanwhile I've attached a patch for the current version with the > non-controversial changes I mentioned above, and also Adding a > $FreeBSD$, and using %%WWWDIR%% throughout instead of creating a > variable for it. The SUB routine for the ports can handle as many > substitutions of the same value as you need it to, and this way is > (slightly) more efficient, and (slightly) less confusing. With your > permission I'll commit this fix since Wesley is going to be traveling. Thanks for the patch! At the moment i do not have a possibility to double c= heck them but the changes look good to me so please feel free to commit the= m. -- Bernhard Fr=C3=B6hlich=20 http://www.bluelife.at/