Date: Mon, 13 May 2013 21:22:59 +0200 From: Lars Engels <lars.engels@0x20.net> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Lars Engels <lme@FreeBSD.org>, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r317834 - head/astro/swe Message-ID: <20130513192259.GB32935@e-new.0x20.net> In-Reply-To: <20130511110110.GA92017@FreeBSD.org> References: <201305101828.r4AISZWi094449@svn.freebsd.org> <20130511091807.GA67148@FreeBSD.org> <20130511095605.GV32935@e-new.0x20.net> <20130511110110.GA92017@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Nm48CqPeykZpOG4/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 11, 2013 at 11:01:10AM +0000, Alexey Dokuchaev wrote: > On Sat, May 11, 2013 at 11:56:05AM +0200, Lars Engels wrote: > > On Sat, May 11, 2013 at 09:18:07AM +0000, Alexey Dokuchaev wrote: > > > On Fri, May 10, 2013 at 06:28:35PM +0000, Lars Engels wrote: > > > > New Revision: 317834 > > > > URL: http://svnweb.freebsd.org/changeset/ports/317834 > > > >=20 > > > > @@ -24,6 +24,10 @@ post-patch: > > > > -e 's|CFLAGS =3D|CFLAGS ?=3D|' \ > > > > ${WRKSRC}/Makefile > > > > =20 > > > > +.if ${OSVERSION} >=3D 100000 > > > > + @${REINPLACE_CMD} -e 's|-O9|-O3|' ${WRKSRC}/Makefile > > > > +.endif > > >=20 > > > Any reason for this fix being conditional on OSVERSION? > >=20 > > I assumed that -O9 didn't work with CLANG on current, but I just checked > > this and the port gets automatically build with -O2. > > I'll talk about it with the PR submitter if it's necessary. >=20 > It would be awesome if the port could be teached to uphold our CFLAGS > instead of using hardcoded (very bogus) -O9 or whatever. >=20 Yes, you're right. The maintainer approved the removal of the conditional and in the post-patch section there's already the patch to use our CFLAGS. --Nm48CqPeykZpOG4/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGRPZMACgkQKc512sD3afg5lACeMCeMx+gE17vXbGj7JJP+743n NAUAn0kEMNBjkjV5tROmC2KWxqkfbYza =D8Sh -----END PGP SIGNATURE----- --Nm48CqPeykZpOG4/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130513192259.GB32935>