From owner-svn-src-head@FreeBSD.ORG Thu Nov 6 17:02:45 2008 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBA23106568E; Thu, 6 Nov 2008 17:02:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 9876C8FC08; Thu, 6 Nov 2008 17:02:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mA6H295k053629; Thu, 6 Nov 2008 10:02:09 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 06 Nov 2008 10:03:23 -0700 (MST) Message-Id: <20081106.100323.195417660.imp@bsdimp.com> To: danfe@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20081106101156.GA40311@FreeBSD.org> References: <20081105.144840.-432836001.imp@bsdimp.com> <864p2l5hf1.fsf@ds4.des.no> <20081106101156.GA40311@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, alfred@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184610 - in head: lib/libusb20 share/man/man4 sys/conf sys/dev/sound/pcm sys/dev/usb2 sys/dev/usb2/bluetooth sys/dev/usb2/controller sys/dev/usb2/core sys/dev/usb2/ethernet sys/dev/usb... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2008 17:02:46 -0000 In message: <20081106101156.GA40311@FreeBSD.org> Alexey Dokuchaev writes: : On Thu, Nov 06, 2008 at 10:32:02AM +0100, Dag-Erling Sm??rgrav wrote: : > "M. Warner Losh" writes: : > > Dag-Erling_Sm??rgrav writes: : > > > It looks like whoever wrote this went out of their way to find new and : > > > creative ways to break just about every style rule we have. : > > Not just coding style, but also style of /dev entries, the modules : > > style, etc. : > : > So the question is, why was this code imported at all? : : Seconded, especially since it says the code was reviewed by you Warner in : the commit log. Unfortunately, most of my reviews were ignored, as were those of a great many other people. There's lots of pressure for this code from the user community. It is an experiment, one that may well ultimately fail. Warner