Date: Fri, 22 Jan 2010 21:44:58 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: Tobias Rehbein <tobias.rehbein@web.de> Cc: freebsd-current@freebsd.org Subject: Re: [patch] Let indent(1) handle widecharacter literals correctly Message-ID: <20100122104457.GB31243@server.vk2pj.dyndns.org> In-Reply-To: <20100121210523.GA1442@sushi.pseudo.local> References: <20100121210523.GA1442@sushi.pseudo.local>
next in thread | previous in thread | raw e-mail | index | archive | help
--b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2010-Jan-21 22:05:23 +0100, Tobias Rehbein <tobias.rehbein@web.de> wrote: >I am not subscribed to this list, so please answer me off-list or cc me. > >I noticed that indent(1) handles widecharacter literals (e.g. L'c' or L"st= ring") >incorrectly. indent(1)s parser treats the L-prefix and the quoted part as >seperate tokens. The result is: > > L'c' -> L 'c' > L"string" -> L "string" Thank you for noticing that. Can you please submit your patch as a PR so it doesn't get lost (send-pr(1)). >Of course this breaks any code using widecharacters. As I use indent(1) qu= ite >extensively I decided to fix this issue. As this is my first patch against= the >FreeBSD user land feel free to comment! I don't know indent(1) well enough to comment on the functional aspects but there are some style issues with the patch. Two lines are longer than 80 characters and the indenting doesn't align - see style(9). --=20 Peter Jeremy --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAktZgakACgkQ/opHv/APuIfI8ACgo7h/ZIyVAjDIChfqVJK1ZDBb 8KEAn2T3QixIbxZpNgRPd9kGhXn9j+rT =2TJK -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100122104457.GB31243>