From owner-svn-src-all@FreeBSD.ORG Wed Jan 28 17:53:44 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CF94106566B; Wed, 28 Jan 2009 17:53:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id DFAA98FC14; Wed, 28 Jan 2009 17:53:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 7CE5B46B5C; Wed, 28 Jan 2009 12:53:43 -0500 (EST) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n0SHrbP1098530; Wed, 28 Jan 2009 12:53:37 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Wed, 28 Jan 2009 12:53:13 -0500 User-Agent: KMail/1.9.7 References: <200901280111.n0S1BL7n003092@svn.freebsd.org> <873af38tln.fsf@kobe.laptop> <20090128.100532.270753022.imp@bsdimp.com> In-Reply-To: <20090128.100532.270753022.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901281253.13907.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 28 Jan 2009 12:53:37 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8914/Wed Jan 28 01:40:00 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: keramida@ceid.upatras.gr, trhodes@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r187805 - head/lib/libc/stdio X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 17:53:44 -0000 On Wednesday 28 January 2009 12:05:32 pm M. Warner Losh wrote: > In message: <873af38tln.fsf@kobe.laptop> > Giorgos Keramidas writes: > : On Wed, 28 Jan 2009 01:11:21 +0000 (UTC), Tom Rhodes wrote: > : > Author: trhodes > : > Date: Wed Jan 28 01:11:20 2009 > : > New Revision: 187805 > : > URL: http://svn.freebsd.org/changeset/base/187805 > : > > : > Log: > : > Remove comment about clearerr() being the only method of clearing > : > the EOF indicator, fseek() may also be used for this. > : > > : > Bump document date. > : > : I don't like this, sorry... Having a pointer to clearerr() is nice. > : Removing it *deletes* useful information, but we should add _more_ of > : it. > : > : How about this instead? > : > : The end-of-file indicator may be cleared by explicitly calling > : .Fn clearerr , > : or as a side-effect of other operations, i.e.\& > : .Fn fseek . > > s/fseek/lseek/ clearerr(), fseek() etc. are all stdio routines. It would be a bit hard for lseek(2) to clear the error flag in the FILE struct in userland. :) -- John Baldwin