From owner-p4-projects@FreeBSD.ORG Tue Apr 10 13:19:49 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4C6DD16A40A; Tue, 10 Apr 2007 13:19:49 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E868916A408 for ; Tue, 10 Apr 2007 13:19:48 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D6E6813C46E for ; Tue, 10 Apr 2007 13:19:48 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3ADJmg5011321 for ; Tue, 10 Apr 2007 13:19:48 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3ADJmai011318 for perforce@freebsd.org; Tue, 10 Apr 2007 13:19:48 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Tue, 10 Apr 2007 13:19:48 GMT Message-Id: <200704101319.l3ADJmai011318@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 117838 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2007 13:19:49 -0000 http://perforce.freebsd.org/chv.cgi?CH=117838 Change 117838 by rwatson@rwatson_zoo on 2007/04/10 13:19:18 We do allow POSIX message queue privileges in jail in almost all cases, so make it all. Affected files ... .. //depot/projects/trustedbsd/priv/sys/kern/uipc_mqueue.c#8 edit Differences ... ==== //depot/projects/trustedbsd/priv/sys/kern/uipc_mqueue.c#8 (text+ko) ==== @@ -961,12 +961,9 @@ sx_assert(&pn->mn_info->mi_lock, SX_LOCKED); - /* - * XXXRW: Other instances of the message queue primitive are - * allowed in jail? - */ if (ucred->cr_uid != pn->mn_uid && - (error = priv_check_cred(ucred, PRIV_MQ_ADMIN, 0)) != 0) + (error = priv_check_cred(ucred, PRIV_MQ_ADMIN, + SUSER_ALLOWJAIL)) != 0) error = EACCES; else if (!pn->mn_deleted) { parent = pn->mn_parent;