Date: Wed, 16 Oct 2013 03:00:01 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-net@FreeBSD.org Subject: Re: bin/175974: commit references a PR Message-ID: <201310160300.r9G301Uw042532@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/175974; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/175974: commit references a PR Date: Wed, 16 Oct 2013 02:55:39 +0000 (UTC) Author: kevlo Date: Wed Oct 16 02:55:31 2013 New Revision: 256574 URL: http://svnweb.freebsd.org/changeset/base/256574 Log: Fix logic error. MPPE only accepts protocol numbers 0x21 through 0xFA. PR: bin/175974 Modified: head/usr.sbin/ppp/mppe.c Modified: head/usr.sbin/ppp/mppe.c ============================================================================== --- head/usr.sbin/ppp/mppe.c Wed Oct 16 02:46:00 2013 (r256573) +++ head/usr.sbin/ppp/mppe.c Wed Oct 16 02:55:31 2013 (r256574) @@ -168,7 +168,7 @@ MPPEOutput(void *v, struct ccp *ccp, str dictinit = 0; log_Printf(LogDEBUG, "MPPE: Output: Proto %02x (%d bytes)\n", *proto, ilen); - if (*proto < 0x21 && *proto > 0xFA) { + if (*proto < 0x21 || *proto > 0xFA) { log_Printf(LogDEBUG, "MPPE: Output: Not encrypting\n"); ccp->compout += ilen; ccp->uncompout += ilen; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310160300.r9G301Uw042532>