From owner-freebsd-net@FreeBSD.ORG  Wed Oct 16 03:00:01 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id B74B2E58
 for <freebsd-net@smarthost.ysv.freebsd.org>;
 Wed, 16 Oct 2013 03:00:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A4CC1299E
 for <freebsd-net@smarthost.ysv.freebsd.org>;
 Wed, 16 Oct 2013 03:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9G301px042533
 for <freebsd-net@freefall.freebsd.org>; Wed, 16 Oct 2013 03:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9G301Uw042532;
 Wed, 16 Oct 2013 03:00:01 GMT (envelope-from gnats)
Date: Wed, 16 Oct 2013 03:00:01 GMT
Message-Id: <201310160300.r9G301Uw042532@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: bin/175974: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2013 03:00:01 -0000

The following reply was made to PR bin/175974; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/175974: commit references a PR
Date: Wed, 16 Oct 2013 02:55:39 +0000 (UTC)

 Author: kevlo
 Date: Wed Oct 16 02:55:31 2013
 New Revision: 256574
 URL: http://svnweb.freebsd.org/changeset/base/256574
 
 Log:
   Fix logic error.  MPPE only accepts protocol numbers 0x21 through 0xFA.
   
   PR:	bin/175974
 
 Modified:
   head/usr.sbin/ppp/mppe.c
 
 Modified: head/usr.sbin/ppp/mppe.c
 ==============================================================================
 --- head/usr.sbin/ppp/mppe.c	Wed Oct 16 02:46:00 2013	(r256573)
 +++ head/usr.sbin/ppp/mppe.c	Wed Oct 16 02:55:31 2013	(r256574)
 @@ -168,7 +168,7 @@ MPPEOutput(void *v, struct ccp *ccp, str
    dictinit = 0;
  
    log_Printf(LogDEBUG, "MPPE: Output: Proto %02x (%d bytes)\n", *proto, ilen);
 -  if (*proto < 0x21 && *proto > 0xFA) {
 +  if (*proto < 0x21 || *proto > 0xFA) {
      log_Printf(LogDEBUG, "MPPE: Output: Not encrypting\n");
      ccp->compout += ilen;
      ccp->uncompout += ilen;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"