From owner-freebsd-mips@FreeBSD.ORG Wed Jun 30 23:05:27 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 115F9106566C; Wed, 30 Jun 2010 23:05:27 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8DA598FC08; Wed, 30 Jun 2010 23:05:26 +0000 (UTC) Received: by vws6 with SMTP id 6so568112vws.13 for ; Wed, 30 Jun 2010 16:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=CIWhIvo6vUOtZ5UkBPKNC6sWso4VVnf5ASxb1g/uwFo=; b=ouhuI5i0iTb7USvvNVoGH9zZc+sRBNP8X/7lbFiNpmVw/Xq+oyQtCgp+KkLKcpF/80 RQdCFr4nQwwTfc4yYsUAANR3OmtjtcrMvPu43iPE3GPmjy3mwcOaHpwc290t1lDXzsjt 4y/PS5jKd9Ijuonw4fKmNWiHTqpIzOa4n7SM0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=cS1mCFTCBkeEutmEx64zG6L923sGHQgC6NmOXkrja2pfDKNkQK38YtwFljwwkMSqoM GaiCJroRKYUtcMv2xVnuV0jSPQVxCZ34vOrsqJoSwfwJXp6UXf59i6TWu3i3hD1mTZ0O x1xHnqTVFJMfwn0gUsJZu/rI6H4J+nmLFnGXY= MIME-Version: 1.0 Received: by 10.220.168.12 with SMTP id s12mr2916731vcy.69.1277939123219; Wed, 30 Jun 2010 16:05:23 -0700 (PDT) Received: by 10.220.194.4 with HTTP; Wed, 30 Jun 2010 16:05:23 -0700 (PDT) In-Reply-To: References: <897604F6-95C4-49A8-B11F-277A74C8DBAE@gmail.com> <3C0AEF9B-AE0C-4459-A4E1-2C8C30C10FD6@gmail.com> <25B9A19D-0A6B-4731-8FB1-A2C6722F0E9C@gmail.com> Date: Thu, 1 Jul 2010 04:35:23 +0530 Message-ID: From: "Jayachandran C." To: Juli Mallett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2010 23:05:27 -0000 On Thu, Jul 1, 2010 at 4:17 AM, Juli Mallett wrote: > On Wed, Jun 30, 2010 at 15:40, Jayachandran C. = wrote: >> I've attached the final(final.diff) version I want to check-in, can >> you please quickly test it? >> >> If that does not work, can you tell me if the attached alt1.diff or >> alt2.diff works? The try.diff had three changes: handle case of >> index>0, remove pagemask operation, restore full entryhi instead of >> asid. So if the first does not work, this will help narrow down the >> rest of the cases. >> >> Hopefully this is the last iteration :) > > Hi JC, > > I think you're right that the issue is not masking enough bits in > EntryHi. =A0I suspect the other changes are not necessary and I feel > that the change to always add the entry if it doesn't exist is > undesirable if it's unnecessary. =A0When a lot of otherwise-unused > mappings are changing, this has the effect of spilling the TLB which > kills performance. =A0I hope someone is willing to try just the > TLBHI_ENTRY changes to make sure that fixes it. I had a patch that did just the EntryHi thing (the ealier mail pte.h-fix.diff), and that did not fix the issue, that is why I just ended up doing what the original code did. Also, I don't think the pagemask read/write is necessary, it should not have any effect, as far i can see. JC.