Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Jun 2002 18:26:03 -0700 (PDT)
From:      Julian Elischer <julian@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 13551 for review
Message-ID:  <200206290126.g5T1Q3Xf063565@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=13551

Change 13551 by julian@julian_ref on 2002/06/28 18:25:56

	Don't need Giant pre-set for userret()

Affected files ...

.. //depot/projects/kse/sys/i386/i386/trap.c#55 edit

Differences ...

==== //depot/projects/kse/sys/i386/i386/trap.c#55 (text+ko) ====

@@ -1076,6 +1076,12 @@
 	}
 
 	/*
+	 * Release Giant if we previously set it.
+	 */
+	if ((callp->sy_narg & SYF_MPSAFE) == 0)
+		mtx_unlock(&Giant);
+
+	/*
 	 * Traced syscall.
 	 */
 	if ((orig_tf_eflags & PSL_T) && !(orig_tf_eflags & PSL_VM)) {
@@ -1088,12 +1094,6 @@
 	 */
 	userret(td, &frame, sticks);
 
-	/*
-	 * Release Giant if we previously set it.
-	 */
-	if ((callp->sy_narg & SYF_MPSAFE) == 0)
-		mtx_unlock(&Giant);
-
 #ifdef KTRACE
 	if (KTRPOINT(td, KTR_SYSRET))
 		ktrsysret(code, error, td->td_retval[0]);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206290126.g5T1Q3Xf063565>