Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Jun 2017 19:39:39 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Koop Mast <kwm@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r443040 - in head/lang: . spidermonkey38 spidermonkey38/files
Message-ID:  <y3sy-whic-wny@FreeBSD.org>
In-Reply-To: <201706092008.v59K8sOI058935@repo.freebsd.org> (Koop Mast's message of "Fri, 9 Jun 2017 20:08:54 %2B0000 (UTC)")
References:  <201706092008.v59K8sOI058935@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Koop Mast <kwm@FreeBSD.org> writes:

> Modified: head/lang/spidermonkey38/files/patch-bug702179
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/lang/spidermonkey24/files/patch-bug702179	Fri Jun  9 19:46:11 20=
17	(r443039)
> +++ head/lang/spidermonkey38/files/patch-bug702179	Fri Jun  9 20:08:54 20=
17	(r443040)
> @@ -1,23 +1,18 @@
> -diff --git js/src/Makefile.in js/src/Makefile.in
> -index e28160a..28ca5e8 100644
> ---- Makefile.in
> +--- Makefile.in.orig	2017-06-05 19:05:02 UTC
>  +++ Makefile.in
> -@@ -35,7 +35,6 @@ ifdef JS_SHARED_LIBRARY
> - FORCE_SHARED_LIB =3D 1
> - endif
> - FORCE_STATIC_LIB =3D 1
> --DIST_INSTALL =3D 1
> +@@ -208,10 +208,13 @@ endif
> + SCRIPTS =3D $(JS_CONFIG_NAME)
> + SDK_BINARY =3D $(JS_CONFIG_NAME)
>=20=20=20
> - ###############################################
> - # BEGIN include sources for low-level code shared with mfbt
> -@@ -584,8 +584,8 @@ install:: $(EXPORTS_mozilla)
> - install:: $(SCRIPTS)
> - 	$(SYSINSTALL) $^ $(DESTDIR)$(bindir)
> +-$(LIBRARY_NAME).pc: js.pc
> ++$(JS_CONFIG_NAME): js-config

The patch file is named after Mozilla bug 702179 but the contents no
longer match. Did you check DTrace probes still work? Perhaps, you want
the following:

  $ cd /usr/ports/lang/spidermonkey38
  $ svn mv files/patch-bug702179 files/patch-Makefile.in
  $ svn cp ../../www/firefox-esr/files/patch-bug702179@413725 files/
  $ sed -i '' 's,js/src/,,' files/patch-bug702179
  $ sed -n '/install/,$p' ../spidermonkey24/files/patch-bug702179 >>files/p=
atch-bug702179
  $ sed -i '' '/libjs_static/d' Makefile
  $ ../../Tools/scripts/bump-revision.sh .

https://svnweb.freebsd.org/ports/head/www/firefox-esr/files/patch-bug702179=
?revision=3D413725&view=3Dmarkup
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D192614#c0

> + 	cp $^ $@
>=20=20=20
> --install:: $(REAL_LIBRARY) $(SHARED_LIBRARY) $(IMPORT_LIBRARY)
> --ifneq (,$(REAL_LIBRARY))
> -+install:: $(LIBRARY) $(SHARED_LIBRARY) $(IMPORT_LIBRARY)
> -+ifdef DIST_INSTALL
> - 	$(SYSINSTALL) $(REAL_LIBRARY) $(DESTDIR)$(libdir)
> - 	mv -f $(DESTDIR)$(libdir)/$(REAL_LIBRARY) $(subst $(STATIC_LIBRARY_NAM=
E),$(LIBRARY_NAME),$(DESTDIR)$(libdir)/$(REAL_LIBRARY))
> - endif
> +-install:: $(LIBRARY_NAME).pc
> ++$(JS_LIBRARY_NAME).pc: js.pc
> ++	cp $^ $@
> ++
> ++install:: $(JS_LIBRARY_NAME).pc
> + 	$(SYSINSTALL) $^ $(DESTDIR)$(prefix)/libdata/pkgconfig
> +=20
> + install:: js-config.h

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQF8BAEBCgBmBQJZPYBbXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b1aMH/3RO89ZQ5wd4TWOnziQyqgOF
JW19MqTtccOBLginWC/seLbGyxIj/RdiEtAZCMQiPcwWNRtGgtG1b3AS2UgoqtxW
5rTLSZL4SGWHq4mCLFGlG7Q0ek/n7jUdNmgjwKuWfTKMubgpUtHqNiNGZ5KBHS/h
KkjyHXe+FEiCoHlCINXBrUHB3IIOua0yd01CMDBiesip6rOPkHU1zyxPZ+vMvGNB
bYemceCnyDJjcOfoyErUZAz4BLwdZSg9PNpz/ckEgxokjq0isUxFkj8WqPgb1pvE
X/Odw1iRYUQvMwHqbSsS55w0oqarF9Fg37BM/8wBac6uySw79etk4kxA0j/21R8=
=JBAT
-----END PGP SIGNATURE-----
--=-=-=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y3sy-whic-wny>