Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Dec 2011 03:30:12 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-bugs@FreeBSD.org
Subject:   Re: kern/163098: commit references a PR
Message-ID:  <201112080330.pB83UCkv080050@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163098; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/163098: commit references a PR
Date: Thu,  8 Dec 2011 03:20:52 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Thu Dec  8 03:20:38 2011
 New Revision: 228343
 URL: http://svn.freebsd.org/changeset/base/228343
 
 Log:
   - Fix ktrace leakage if error is set
   
   PR:		kern/163098
   Submitted by:	Loganaden Velvindron <loganaden@devio.us>
   Approved by:	sbruno@
   MFC after:	1 month
 
 Modified:
   head/sys/kern/kern_ktrace.c
 
 Modified: head/sys/kern/kern_ktrace.c
 ==============================================================================
 --- head/sys/kern/kern_ktrace.c	Thu Dec  8 02:40:46 2011	(r228342)
 +++ head/sys/kern/kern_ktrace.c	Thu Dec  8 03:20:38 2011	(r228343)
 @@ -478,7 +478,7 @@ ktrsysret(code, error, retval)
  	ktp = &req->ktr_data.ktr_sysret;
  	ktp->ktr_code = code;
  	ktp->ktr_error = error;
 -	ktp->ktr_retval = retval;		/* what about val2 ? */
 +	ktp->ktr_retval = ((error == 0) ? retval: 0);		/* what about val2 ? */
  	ktr_submitrequest(curthread, req);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112080330.pB83UCkv080050>