Date: Thu, 29 Jun 2017 09:10:53 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219687] [NEW PORT] net/google-compute-engine: user daemon for Google Compute Engine Message-ID: <bug-219687-13-JIuaHFANHa@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-219687-13@https.bugs.freebsd.org/bugzilla/> References: <bug-219687-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687 --- Comment #7 from Richard Gallamore <ultima@freebsd.org> --- (In reply to Helen Koike from comment #5) > This match upstream, it is just the github tag that is by date, the versi= on is in the setup.py file as shown here > https://github.com/GoogleCloudPl= atform/compute-image-packages/commit/5824f1bba1906f6bb298db2efaf1bffc0671ff= 45 I think the other versioning would be better, please change it back. I just wanted to verify correct versioning is being use. > Done, I added just before "post-patch:" target, is it ok now? Perfect. > I also adjusted pkg-desc so lines don't exceed 80 characters > And I removed DISTVERSION (as it cannot be user with PORTVERSION) There isn't really a character limit on pkg-descr. This looks descriptive enough to me.=20 > But now it uses version 20170609 instead of 2.4.0, is this ok? I feel tha= t 2.4.0 should be somewhere as it is the version used in setup.py, what do = you think? > I tried to use GH_TAGNAME=3D20170609 with PORTVERSION=3D2.4.0 but it does= n't seem to work the way I imagined Yes, revert back to how it was previously. This was a better solution, just needed to verify. > With these changes now portlint returns: > # portlint -AC > looks fine. This is great. Couple things with the poudriere log. - Only the port listed in summary is required, in this case net/google-compute-engine. - Not sure how the build was invoked, but I usually use poudriere bulk -tC.= (-t is for extra testing and -C will clean the specified package before build) I also want to note that poudriere bulk is not the recommended procedure. F= rom the porters handbook, testport is suggested method, details here[1]. When I initially went to the github repo, for some odd reason the README.md= did not show up and was just blank with no information. Going back to it now, t= he information I was expecting is shown, so this work perfectly for WWW. There= are some other items that need to be will need to be looked at. - Portname. Usually this is the same as project name, but I don't think that would be a good fit. google-compute-image would be a bit more accurate, but more opinions would be best. - The comment should match the project comment on github minus "Linux". Changing this however with the current portname is a violation of having the portname in comment so waiting for portname feedback before deciding the correct comment. - pkg-message.in[2]. Can you please provide a simple setup guide. It doesn't need to be long, just a simple how-to startup guide of procedures required after installing the package for the first time. If configuration is requir= ed, pointing to a url with more information would be great. One more bit of information, how was the port tested? or is the port curren= tly being used in production? Thanks for your efforts on this port! [1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#testing-pou= driere [2] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-mes= sage --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-219687-13-JIuaHFANHa>