From owner-cvs-all@FreeBSD.ORG  Tue Apr 19 19:25:13 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7066D16A4CE; Tue, 19 Apr 2005 19:25:13 +0000 (GMT)
Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 11E5743D1D; Tue, 19 Apr 2005 19:25:13 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	j3JJPCpx028671;	Tue, 19 Apr 2005 15:25:12 -0400 (EDT)
Date: Tue, 19 Apr 2005 15:25:12 -0400 (EDT)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: Hajimu UMEMOTO <ume@freebsd.org>
In-Reply-To: <Pine.GSO.4.43.0504191516330.6115-100000@sea.ntplx.net>
Message-ID: <Pine.GSO.4.43.0504191523340.6115-100000@sea.ntplx.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net)
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/lib/libc/net getproto.c getprotoent.c        
 getprotoname.c netdb_private.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2005 19:25:13 -0000

On Tue, 19 Apr 2005, Daniel Eischen wrote:

> On Wed, 20 Apr 2005, Hajimu UMEMOTO wrote:
>
> > Hi,
> >
> > deischen> Stop polluting the namespace.  If the externally visible functions
> > deischen> you add are not in a standard and are only for use within libc,
> > deischen> they need to be prefixed with "_" or "__".  I haven't paid attention
> > deischen> to your other commits in libc, but please go back and fix other
> > deischen> occurrences if there are any.  Or make them static if they can
> > deischen> be.
> >
> > The functions I added are prefixed with `__'.
>
> Look at src/lib/libc/net/getprotoent.c (the only file I examined).
> You added getprotoent_r, setprotoent_r, and endprotoent_r.  Even
> your commit message says this ;-)  These functions are not in the
> POSIX spec as far as I can see.

Nevermind.  I just saw the #defines in netdb_private.h.  Is there
a reason why these are all #defined instead of just being declared
as __foo()?

-- 
Dan Eischen