From owner-cvs-gnu  Wed Nov 20 23:31:48 1996
Return-Path: owner-cvs-gnu
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id XAA10736
          for cvs-gnu-outgoing; Wed, 20 Nov 1996 23:31:48 -0800 (PST)
Received: from ghpc6.ihf.rwth-aachen.de (ghpc6.ihf.RWTH-Aachen.DE [134.130.90.6])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id XAA10731;
          Wed, 20 Nov 1996 23:31:16 -0800 (PST)
Received: (from thomas@localhost) by ghpc6.ihf.rwth-aachen.de (8.6.12/8.6.9) id IAA16339; Thu, 21 Nov 1996 08:24:26 +0100
From: Thomas Gellekum <thomas@ghpc8.ihf.rwth-aachen.de>
Message-Id: <199611210724.IAA16339@ghpc6.ihf.rwth-aachen.de>
Subject: Re: cvs commit:  src/gnu/lib/libregex Makefile regex.c
To: joerg@freefall.freebsd.org (Joerg Wunsch)
Date: Thu, 21 Nov 1996 08:24:25 +0100 (MET)
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-gnu@freefall.freebsd.org
In-Reply-To: <199611201506.HAA09692@freefall.freebsd.org> from Joerg Wunsch at "Nov 20, 96 07:06:01 am"
Organization: Institut f. Hochfrequenztechnik, RWTH Aachen
X-Mailer: ELM [version 2.4ME+ PL11 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-gnu@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Joerg Wunsch wrote:
> joerg       96/11/20 07:05:57
> 
>   Branch:      gnu/lib/libregex  RELENG_2_2
>   Modified:    gnu/lib/libregex  Makefile regex.c
>   Log:
>   Merge from HEAD: don't duplicate the Posix regex stuff in libregex,
>   it's already in libc (and both implementations clash when linking both
>   libs simultaneously).

While you're at it: when testing a new port I found that there are
multiple definitions of regerror in libcompat:

regerror.o:
00000000 T _regerror

regex.o:
         U _free
00000020 T _re_comp
000000a0 T _re_exec
         U _regcomp
000000e0 T _regerror
         U _regexec
         U _strdup

Which one of those do we really need there?

A second thing: /usr/include/regex.h doesn't `#define REG_NOERROR 0'
which was expected by this port. I don't know if this one comes from
POSIX or if it was just some ``vendor extension''.

tg