Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Oct 2009 18:27:33 +1100
From:      Peter Jeremy <peterjeremy@acm.org>
To:        Alexander Kabaev <kabaev@gmail.com>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   Re: svn commit: r198304 - in stable/8/lib/libc: . gen stdio stdtime string sys
Message-ID:  <20091025072732.GA1898@server.vk2pj.dyndns.org>
In-Reply-To: <20091024222400.6575c6f6@kan.dnsalias.net>
References:  <200910201905.n9KJ5hPe075884@svn.freebsd.org> <20091025001231.GA1817@server.vk2pj.dyndns.org> <20091024222400.6575c6f6@kan.dnsalias.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2009-Oct-24 22:24:00 -0400, Alexander Kabaev <kabaev@gmail.com> wrote:
>> bin/139052 discusses a related problem not addressed by r197277.
>> Any chance of looking into that?
>
>You are linking in a library compiled with -fstack-protector
>(libgcov) and do not pass -fstack-protector when running gcc with
>-fprofile-generator. Consequently, gcc does not link in necessary
>libssp_nonshared.a.

Well, that explains what is broken.

>Either you use stack protections or you do not. Please choose.

I haven't specified to use stack protection _anywhere_.  The system
defaults appear to have been changed so that libgcov is (by default)
built with stack protection enabled but gcc doesn't build with stack
protection enabled by default, leading to the breakage I reported.

This is a POLA violation at best and isn't documented anywhere.  If
world is going to be built with stack protection on by default then
the gcc defaults need to be adjusted to suit.  I bumped into this bug
whilst trying to build multimedia/x264 with PGO enabled.  I'm sure I'm
not the only person who is going to get bitten.

--=20
Peter Jeremy

--EeQfGwPcQSOJBaQU
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (FreeBSD)

iEYEARECAAYFAkrj/eQACgkQ/opHv/APuIfskACbBAmE97dhPBgm9wPoUES4BTk4
HmgAnR2CPkU3YL+pybd7tMgrQTxi4kCm
=4g2V
-----END PGP SIGNATURE-----

--EeQfGwPcQSOJBaQU--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091025072732.GA1898>