From owner-svn-src-all@freebsd.org Tue Aug 4 20:07:04 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B02649B3B9A for ; Tue, 4 Aug 2015 20:07:04 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B66AEC3 for ; Tue, 4 Aug 2015 20:07:03 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wibxm9 with SMTP id xm9so38377883wib.1 for ; Tue, 04 Aug 2015 13:07:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=Qxcb9H9ZhLQuo1H5STyyIWknLobEnhB3KongaOyxKWc=; b=U8C6QMYCBqrkRuHnZ5dLEzeVbcypuBCYusB6VLmocffoss+MqUZEbSFnT6Vrag1Mza XndxC2y/iIck0HMXVpOBmePWhsqKpJyJDxIeaITVXn4vYVwauMjEYMyfTqyQqC7K7rKQ Mld748tbBHUFyrsJ4jlDQ8k5xPQaO4iXXqESemRkvMSz+mu0YW5i7sV7gfZEoQlTOOcG +oItaIjgKJv7L3tZeGpxZg0e5yApGKOl6wYufUlAj3w3GkfGvByrfY6Wp4JxHpN/04oy /DJrSr/Rfg500jKplA9hSQ8IxMpGJ9G87Y9EK5FcJNYxedfit7vcboeG/wyCfwt1StX0 s0HQ== X-Gm-Message-State: ALoCoQnE+JiqbalkaVuVZAqLgldMXMkp0TppOekSLxSwwAHPbAJhKTija/x8uzhXFXjf8LKxrgas X-Received: by 10.180.77.40 with SMTP id p8mr2314131wiw.29.1438718822216; Tue, 04 Aug 2015 13:07:02 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id pu6sm508841wjc.34.2015.08.04.13.07.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Aug 2015 13:07:00 -0700 (PDT) Subject: Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Slawa Olhovchenkov References: <20150803094730.GA24698@zxy.spb.ru> <55BF431E.3020601@freebsd.org> <2757800.HIDNx1G49O@overcee.wemm.org> <20150803111942.GB2072@kib.kiev.ua> <55BF557B.60009@multiplay.co.uk> <20150803120359.GC2072@kib.kiev.ua> <55BFC296.5050402@freebsd.org> <20150803194412.GC8792@zxy.spb.ru> <55C07826.9070002@multiplay.co.uk> <20150804161448.GC24698@zxy.spb.ru> Cc: Warner Losh , src-committers@freebsd.org, Peter Wemm , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Konstantin Belousov , Julian Elischer From: Steven Hartland Message-ID: <55C11B5F.2080007@multiplay.co.uk> Date: Tue, 4 Aug 2015 21:06:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150804161448.GC24698@zxy.spb.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 20:07:04 -0000 On 04/08/2015 17:14, Slawa Olhovchenkov wrote: > On Tue, Aug 04, 2015 at 09:30:30AM +0100, Steven Hartland wrote: > >> >> On 03/08/2015 21:48, Warner Losh wrote: >>>> On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov wrote: >>>> >>>> On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote: >>>> >>>>> On 8/3/15 8:03 PM, Konstantin Belousov wrote: >>>>>> On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: >>>>>>> For this change I don't want to get into fixing the thread0 stack size, >>>>>>> which can be done later, just >>>>>>> to provide a reasonable warning to the user that smaller values could >>>>>>> cause a panic. >>>>>> Hmm, is it limited to the thread0 only ? I.e., would only increasing >>>>>> the initial thread stack size be enough to boot the kernel ? The zfs >>>>>> threads do request larger stack size, I know this. >>>>>> >>>>>> Can somebody test the following patch in the i386 configuration which >>>>>> does not boot ? >>>>> I think this is a reasonable thing to do. Thread0 (and proc0) are special. >>>>> I don't see why giving it a specially sized stack would be a problem. >>>> This is always do for ARM. >>>> May be need increase stack size for Thread0 on ARM too? >>> Seems reasonable. There should be a MI way of doing this, but all the code and defines are buried in MD files, so each architecture needs some love to make this a reality. >>> >>> Warner >> In the mean time are people happier with >> https://reviews.freebsd.org/D3279 or should I just leave it using the >> #define until someone has time to work on a full solution? > Checking by #ifdef you check only parametr at time of building zfs.ko, > checking variable you check actual value. > May be check thread stack best if only for current tread. Not sure I follow you as its not a #ifdef check its straight if in the new version i.e. if (kstack_pages < ZFS_MIN_KSTACK_PAGES) { Just in case you didn't notice kib committed a fix for i386 thread0 in r286288 so this may not be needed at all any more which is good news :) Regards Steve