From owner-cvs-all Tue Jul 9 17:25:31 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4248737B400; Tue, 9 Jul 2002 17:25:28 -0700 (PDT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62EEA43E3B; Tue, 9 Jul 2002 17:25:27 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g6A0PEwr005550; Tue, 9 Jul 2002 17:25:18 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Message-Id: <200207100025.g6A0PEwr005550@gw.catspoiler.org> Date: Tue, 9 Jul 2002 17:25:14 -0700 (PDT) From: Don Lewis Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c To: silby@silby.com Cc: peter@wemm.org, luigi@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20020709161527.Q24213-100000@patrocles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 9 Jul, Mike Silbersack wrote: > > On Tue, 9 Jul 2002, Don Lewis wrote: > >> On 8 Jul, Mike Silbersack wrote: >> >> > + if (sc->tx_queued == 0) >> > + ifp->if_timer = 0; >> > >> > Give that a whirl and see if it solves the problem. >> >> So far nothing evil has happened ;-) > > Ok, I'll commit it later tonight unless Luigi beats me to it. > > /me ponders how interesting bug reporting will get if "evil" is another > option besides "works" or "does not work". I couldn't tell if it actually fixed the bug because I stopped getting the fxp timeouts even before I applied this patch, probably because I wasn't doing the proper stuff to trigger the bug. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message