From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jan 20 13:40:09 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59EDA1065676 for ; Wed, 20 Jan 2010 13:40:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1FB068FC17 for ; Wed, 20 Jan 2010 13:40:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0KDe8Lg096273 for ; Wed, 20 Jan 2010 13:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0KDe8NU096272; Wed, 20 Jan 2010 13:40:08 GMT (envelope-from gnats) Resent-Date: Wed, 20 Jan 2010 13:40:08 GMT Resent-Message-Id: <201001201340.o0KDe8NU096272@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, TAOKA Fumiyoshi Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B2E571065693 for ; Wed, 20 Jan 2010 13:34:02 +0000 (UTC) (envelope-from fmysh@quad.dyndns.org) Received: from aqua.quad.dyndns.org (unknown [IPv6:2001:240:66e::2]) by mx1.freebsd.org (Postfix) with ESMTP id 88E628FC0A for ; Wed, 20 Jan 2010 13:34:02 +0000 (UTC) Received: by aqua.quad.dyndns.org (Postfix, from userid 1001) id 35371153444; Wed, 20 Jan 2010 22:34:01 +0900 (JST) Message-Id: <20100120133401.35371153444@aqua.quad.dyndns.org> Date: Wed, 20 Jan 2010 22:34:01 +0900 (JST) From: TAOKA Fumiyoshi To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Takefu , TAOKA Fumiyoshi Subject: ports/143016: mail/p5-Mail-SpamAssassin: portlint complains X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: TAOKA Fumiyoshi List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2010 13:40:09 -0000 >Number: 143016 >Category: ports >Synopsis: mail/p5-Mail-SpamAssassin: portlint complains >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 20 13:40:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: TAOKA Fumiyoshi >Release: >Organization: >Environment: >Description: Portlint pointed out 2 fatal errors. Here is a fix which was originally submitted by Takefu for ports/141776. >How-To-Repeat: # portlint FATAL: Makefile: [212]: contiguous blank lines (> 1 lines) found. FATAL: Makefile: [74]: USE_OPENSSL is set after including bsd.port.pre.mk. WARN: Makefile: possible use of absolute pathname "/var/db/spamassassin". WARN: Makefile: possible use of absolute pathname "/var/spool/spamd". WARN: Makefile: "RUN_DEPENDS" has to appear earlier. WARN: Makefile: do not set RUN_DEPENDS to ${BUILD_DEPENDS}. Instead, explicity list out required RUN_DEPENDS dependencies. WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples. 2 fatal errors and 5 warnings found. >Fix: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/mail/p5-Mail-SpamAssassin/Makefile,v retrieving revision 1.126 diff -u -r1.126 Makefile --- Makefile 22 Jul 2009 16:26:48 -0000 1.126 +++ Makefile 20 Jan 2010 13:22:51 -0000 @@ -53,6 +53,10 @@ SPF_QUERY "Add SPF query support" off \ RELAY_COUNTRY "Relay country support" off +.if !defined(WITHOUT_SSL) +USE_OPENSSL= yes +.endif + .include .if defined (WITH_SPAMC) @@ -71,7 +75,6 @@ .if !defined(WITHOUT_SSL) .include "${PORTSDIR}/Mk/bsd.openssl.mk" RUN_DEPENDS+= ${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL -USE_OPENSSL= yes CFLAGS+= -I${OPENSSLINC} LDFLAGS+= -L${OPENSSLLIB} CONFIGURE_ARGS+= ENABLE_SSL=yes @@ -210,7 +213,6 @@ @${REINPLACE_CMD} -e '/^CC =/d; \ s|@SSLCFLAGS@|& $${CFLAGS}|g' ${WRKSRC}/spamc/Makefile.in - .if defined(WITH_RAZOR) ${REINPLACE_CMD} -e '/Razor2/s/^#loadplugin/loadplugin/' ${WRKSRC}/rules/v312.pre .endif >Release-Note: >Audit-Trail: >Unformatted: