Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Apr 2004 13:41:00 +0100
From:      Ceri Davies <ceri@submonkey.net>
To:        Eivind Eklund <eivind@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org
Subject:   Re: files/patch-* pathname separators (was Re: cvs commit: ports/games Makefile ...)
Message-ID:  <20040421124100.GT32710@submonkey.net>
In-Reply-To: <20040421094050.GA5052@FreeBSD.org>
References:  <200404181922.i3IJMkTf044706@repoman.freebsd.org> <20040419032304.GA61048@regency.nsu.ru> <20040419103101.GB26102@dragon.nuxi.com> <20040419110810.GA24385@regency.nsu.ru> <20040420200903.GA6174@dragon.nuxi.com> <20040421094050.GA5052@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--9pS2hy4/DrI8BQlq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 21, 2004 at 09:40:50AM +0000, Eivind Eklund wrote:
> On Tue, Apr 20, 2004 at 01:09:03PM -0700, David O'Brien wrote:
> > On Mon, Apr 19, 2004 at 06:08:10PM +0700, Alexey Dokuchaev wrote:
> > > While particular choice for a separator is arguable, the general sche=
me
> > > for patch-files is not, right?  FWIW, that was my point, not `::' vs.
> > > whatever.
> > >=20
> > > As a side note, I don't really see any problem with `::' or `-'.
> >=20
> > 1. Bash escapes it so it actually becomes 4 characters.
> >    This should not be takeing lightly -- people bitched about '%' in
> >    patch names and they were all changed because its a magic charter for
> >    Perforce and Perforce users could be bothered to escape it.
> >=20
> > 2. With the file name lenths of some of our patches (greater than 80
> >    chars) two characters, when one will do, is annoying.
>=20
> If nobody objects, I'll add the following patch to the porters handbook
> to avoid profileration.
>=20
> Index: book.sgml
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml=
,v
> retrieving revision 1.400
> diff -u -r1.400 book.sgml
> --- book.sgml	16 Apr 2004 15:05:32 -0000	1.400
> +++ book.sgml	21 Apr 2004 09:38:25 -0000
> @@ -617,7 +617,10 @@
>  	  first, <literal>ab</literal> second and so on.  If you wish,
>  	  you can use names that indicate the pathnames of the files that
>  	  are patched, such as <filename>patch-Imakefile</filename> or
> -	  <filename>patch-src-config.h</filename>.  These files should
> +	  <filename>patch-src-config.h</filename>.  Due to issues with
> +	  escaping in <command>bash</command> and <command>Perforce</command>,
	               ^^^^^^^                     ^^^^^^^
These should be marked up with <application />

Ceri

--=20

--9pS2hy4/DrI8BQlq
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAhmvcocfcwTS3JF8RAuCtAJ4mkYPfdEiY5xry5K1THWVnxthfWQCbB3ez
w1L7b7AUQsVW9bpjYXYysyg=
=enhi
-----END PGP SIGNATURE-----

--9pS2hy4/DrI8BQlq--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040421124100.GT32710>