Date: Tue, 22 Mar 2011 22:13:26 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Marius Strobl <marius@alchemy.franken.de> Cc: Roger Hammerstein <cheeky.m@live.com>, freebsd-sparc64@freebsd.org, mm@freebsd.org Subject: Re: sparc64 hang with zfs v28 Message-ID: <20110322211326.GC1882@garage.freebsd.pl> In-Reply-To: <20110322191117.GH15528@alchemy.franken.de> References: <BAY147-w7342A790723770DCE8BD4F9C00@phx.gbl> <BAY147-w229E76D137B7A0DCEB3696F9C70@phx.gbl> <20110307192239.GA31314@alchemy.franken.de> <BAY147-w5926709E28BF613C663D48F9C90@phx.gbl> <20110310185423.GA50419@alchemy.franken.de> <20110319152838.GA8594@alchemy.franken.de> <20110321175632.GA19345@darkthrone.kvedulv.de> <20110321175933.GD2086@garage.freebsd.pl> <BAY147-w266A8BF89A940BDD569D2EF9B40@phx.gbl> <20110322191117.GH15528@alchemy.franken.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--/e2eDi0V/xtL+Mc8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Mar 22, 2011 at 08:11:17PM +0100, Marius Strobl wrote:
> On Tue, Mar 22, 2011 at 01:51:20PM -0400, Roger Hammerstein wrote:
> >=20
> > which is:
> > 1310:
> > 1311: error =3D put_nvlist(zc, configs);
> > 1312:
> > 1313: nvlist_free(configs);
> > 1314:
> > 1315: return (error);
> > 1316:}
> > 1317:
> >=20
>=20
> Uhm, looks like r219089 changed some xcopy{in,out}() into
> ddi_copy{in,out}(), i.e. copy{in,out}() into bcopy(), which
> is just wrong for copying in data in from/out to userspace.
> However, looking at the other uses of ddi_copy{in,out}() it
> generally seems that ddi_copy{in,out}() should be defined to
> copy{in,out}(). With the attached patch at least my simple
> test cases works again. The one remaining xcopyout() in
> zfs_ioctl.c then could be also replaced with a ddi_copyout().
> Not sure how any of this manages to work on x86 :)
Yeah, I found this as well and waiting for my test machine to be free to
test it. Thanks.
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://yomoli.com
--/e2eDi0V/xtL+Mc8
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAk2JEPYACgkQForvXbEpPzSfUwCfTuyZvY82oD1qq34nFbcw/FIb
DrwAoJHrz/HYOQx7+KZw6Dm8Hvu4Rt1T
=yUBm
-----END PGP SIGNATURE-----
--/e2eDi0V/xtL+Mc8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110322211326.GC1882>