From owner-cvs-src@FreeBSD.ORG  Sat Oct  9 15:15:20 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6876E16A4CE; Sat,  9 Oct 2004 15:15:20 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3659243D54; Sat,  9 Oct 2004 15:15:20 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.93] ([66.127.85.93])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id i99FFJWi083148
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 9 Oct 2004 08:15:19 -0700 (PDT)
	(envelope-from sam@errno.com)
Message-ID: <4168009A.303@errno.com>
Date: Sat, 09 Oct 2004 08:15:38 -0700
From: Sam Leffler <sam@errno.com>
Organization: Errrno Consulting
User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <200410091325.i99DPK00097724@repoman.freebsd.org>
In-Reply-To: <200410091325.i99DPK00097724@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf2.c    
 src/share/man/man9 mbuf_tags.9
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Oct 2004 15:15:20 -0000

Gleb Smirnoff wrote:
> glebius     2004-10-09 13:25:19 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/sys              mbuf.h 
>     sys/kern             uipc_mbuf2.c 
>     share/man/man9       mbuf_tags.9 
>   Log:
>   Remove inlined m_tag_free(). Rename _m_tag_free() to m_tag_free()
>   and make it visible (same way as in OpenBSD). Describe usage in manpage.
>   
>   This change is useful for creating custom free methods, which
>   call default free method at their end.
>   
>   While here, make malloc declaration for mbuf tags more informative.
>   

I don't recall your showing me the change to remove m_tag_free in 
mbuf.h.  These change the semantics of calling m_tag_free--before they 
called the method pointer, but now they explicitly call the static 
function which is typically not what is desired.  Your original request 
was solely to expose the _m_tag_free function so that code could access 
it; but you've done far more than that with this commit.  I believe you 
should revert the API change.

	Sam