From owner-freebsd-bugs@FreeBSD.ORG Wed Nov 14 01:02:03 2012 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 61C47F99; Wed, 14 Nov 2012 01:02:03 +0000 (UTC) (envelope-from joshua@roughtrade.net) Received: from pinot.shallow.net (pinot.shallow.net [64.22.125.15]) by mx1.freebsd.org (Postfix) with ESMTP id 7EEEB8FC15; Wed, 14 Nov 2012 01:02:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pinot.shallow.net (Postfix) with ESMTP id 7B41477CDB; Wed, 14 Nov 2012 01:02:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at pinot.shallow.net Received: from pinot.shallow.net ([127.0.0.1]) by localhost (pinot.shallow.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OJHi970J2OjW; Wed, 14 Nov 2012 01:02:00 +0000 (UTC) Received: from [192.168.1.111] (unknown [59.167.119.3]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by pinot.shallow.net (Postfix) with ESMTPSA id 695DC77CD9; Wed, 14 Nov 2012 01:01:59 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: kern/29355: [kernel] [patch] add lchflags support From: Josh Goodall In-Reply-To: <20121113211136.GB27821@lonesome.com> Date: Wed, 14 Nov 2012 12:01:55 +1100 Content-Transfer-Encoding: quoted-printable Message-Id: <7E4E5C28-53D7-4F38-98A3-4646DF8254CF@roughtrade.net> References: <201211132050.qADKoKOk037104@freefall.freebsd.org> <01AD3CCE-D478-4F03-8FD7-935429465B56@roughtrade.net> <20121113211136.GB27821@lonesome.com> To: Mark Linimon X-Mailer: Apple Mail (2.1499) Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2012 01:02:03 -0000 On 14/11/2012, at 8:11 AM, Mark Linimon wrote: > On Wed, Nov 14, 2012 at 08:07:02AM +1100, Josh Goodall wrote: >> The handling of this PR is the reason I stopped contributing to = FreeBSD. >=20 > We simply get more PRs than we can handle. I know that's not an > answer that will satisfy anyone, but it's the truth. >=20 > mcl I filed this PR over a decade ago, so really "we didn't get around to = it" seems like a thin excuse. But there's more to it than that. When originally lodged, I'd been = interested in FreeBSD for a while, contributed several ports and the odd = userland PR, I'd spent a few months learning the kernel structure, = looking for a small real-world project to get started. I liked hacking on FreeBSD a lot; I had hopes of eventually earning a = commit bit. I did a very thorough job on the lchflags patch, finding = every possible userland tool (cp, rm, tape, chflags, mtree etc etc) that = needed to learn about it, and produced a patch that bright (or maybe = cmc) described (very memorably, to me, the hopeful novice) on IRC as "a = textbook example of adding a system call". Man was I proud of that = review. Still, no-one wanted to actually commit it. I figured, oh well, = eventually I'll find a taker. I updated it every now and then to ensure = currency. Then, one day in 2002, mux committed a half-assed lchflags that didn't = have much of the userland stuff, contained a syscall signature = inconsistent of the rest of the VOP_SETATTR calls (making base system = mods much more complicated), and sans credit. No-one seemed to care, and, having had my novice work so brusquely = sidelined, I lost interest in contributing further to FreeBSD and moved = on to other projects. This is all water long under the bridge, of course, but I never went on = the record about it before. Take it as a parable of how to lose a = contributor, if you like. Josh.