Date: Tue, 13 Jan 2015 05:32:52 +0000 (UTC) From: Xin LI <delphij@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r277103 - in head/sys/dev/xen: netback netfront Message-ID: <201501130532.t0D5WqeN077734@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: delphij Date: Tue Jan 13 05:32:51 2015 New Revision: 277103 URL: https://svnweb.freebsd.org/changeset/base/277103 Log: Use the common codepath to handle SIOCGIFADDR. Before this change, the current code handles SIOCGIFADDR the same way with SIOCSIFADDR, which involves full arp_ifinit, et al. They should be unnecessary for SIOCGIFADDR case. Differential Revision: https://reviews.freebsd.org/D1508 Reviewed by: glebius MFC after: 2 weeks Modified: head/sys/dev/xen/netback/netback.c head/sys/dev/xen/netfront/netfront.c Modified: head/sys/dev/xen/netback/netback.c ============================================================================== --- head/sys/dev/xen/netback/netback.c Tue Jan 13 01:40:12 2015 (r277102) +++ head/sys/dev/xen/netback/netback.c Tue Jan 13 05:32:51 2015 (r277103) @@ -2251,7 +2251,6 @@ xnb_ioctl(struct ifnet *ifp, u_long cmd, mtx_unlock(&xnb->sc_lock); break; case SIOCSIFADDR: - case SIOCGIFADDR: #ifdef INET mtx_lock(&xnb->sc_lock); if (ifa->ifa_addr->sa_family == AF_INET) { Modified: head/sys/dev/xen/netfront/netfront.c ============================================================================== --- head/sys/dev/xen/netfront/netfront.c Tue Jan 13 01:40:12 2015 (r277102) +++ head/sys/dev/xen/netfront/netfront.c Tue Jan 13 05:32:51 2015 (r277103) @@ -1741,7 +1741,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, int mask, error = 0; switch(cmd) { case SIOCSIFADDR: - case SIOCGIFADDR: #ifdef INET XN_LOCK(sc); if (ifa->ifa_addr->sa_family == AF_INET) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501130532.t0D5WqeN077734>