Date: Tue, 26 May 2009 08:30:36 -0400 From: John Baldwin <jhb@freebsd.org> To: Kip Macy <kmacy@freebsd.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r192604 - in user/kmacy/releng_7_2_fcs/sys: dev/hwpmc sys Message-ID: <200905260830.36831.jhb@freebsd.org> In-Reply-To: <200905222145.n4MLjhm3019802@svn.freebsd.org> References: <200905222145.n4MLjhm3019802@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 22 May 2009 5:45:43 pm Kip Macy wrote: > Author: kmacy > Date: Fri May 22 21:45:43 2009 > New Revision: 192604 > URL: http://svn.freebsd.org/changeset/base/192604 > > Log: > - remove pmc_kthread_mtx > - replace sleep/wakeup on kthread with a condvar If you do not sleep on the kthread/kproc when waiting for a kthread to exit, then you open up a race window. Usually this matters more for any kthreads that live in a module since the race allows the module to be unmapped before the thread is finished executing code from the module resulting in a fatal page fault in the kernel. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905260830.36831.jhb>