From owner-freebsd-current@FreeBSD.ORG Fri Jul 15 21:44:33 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DC1F16A41C; Fri, 15 Jul 2005 21:44:33 +0000 (GMT) (envelope-from harrycoin@qconline.com) Received: from mail.qconline.com (mail.qconline.com [204.176.110.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2CD543D48; Fri, 15 Jul 2005 21:44:32 +0000 (GMT) (envelope-from harrycoin@qconline.com) Received: from devoffice.qconline.com (unverified [64.4.171.82]) by mail.qconline.com (Vircom SMTPRS 3.1.302.0) with ESMTP id ; Fri, 15 Jul 2005 16:45:16 -0500 Message-Id: <4.3.2.7.2.20050715164008.01f0fdd8@mail.qconline.com> X-Sender: harrycoin@mail.qconline.com X-Mailer: QUALCOMM Windows Eudora Version 4.3.2 Date: Fri, 15 Jul 2005 16:44:22 -0500 To: Nate Lawson ,John Baldwin From: Harry Coin In-Reply-To: <42D82A7F.4050208@root.org> References: <200507121027.14113.jhb@FreeBSD.org> <4.3.2.7.2.20050711121036.02caa348@mail.qconline.com> <200507111626.25124.jhb@FreeBSD.org> <42D2F177.3070101@root.org> <200507121027.14113.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Cc: freebsd-current@FreeBSD.org Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2005 21:44:33 -0000 At 02:28 PM 7/15/2005 -0700, Nate Lawson wrote: >Drivers should not rely on isa_get_logicalid() to determine a boolean "is >PNP?" The architecture manual specifies ISA_PNP_PROBE in non pnp ISA drivers for that purpose. As I understand it, John doesn't like the ugly nature of passing in a null device list for non-pnp ISA drivers. Hard to argue with that. So why not gin up a tiny little boolean kernel function 'device_is_pnp(dev)) ' that does the right thing for non-pnp isa drivers - once -,right after wherever ISA_PNP_PROBE is defined in the kernel? Harry