From owner-freebsd-acpi@FreeBSD.ORG  Tue Jul 11 21:09:20 2006
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
X-Original-To: freebsd-acpi@freebsd.org
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6E35716A4E2
	for <freebsd-acpi@freebsd.org>; Tue, 11 Jul 2006 21:09:20 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 88D5D43D7F
	for <freebsd-acpi@freebsd.org>; Tue, 11 Jul 2006 21:09:13 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k6BL7YUO046943;
	Tue, 11 Jul 2006 15:07:34 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Tue, 11 Jul 2006 15:07:42 -0600 (MDT)
Message-Id: <20060711.150742.1649768833.imp@bsdimp.com>
To: atkin901@yahoo.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <e90md5$q6f$1@sea.gmane.org>
References: <20060711.005639.-233674225.imp@bsdimp.com>
	<e90md5$q6f$1@sea.gmane.org>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Tue, 11 Jul 2006 15:07:35 -0600 (MDT)
Cc: freebsd-acpi@freebsd.org
Subject: Re: sio0 wiring to a resource patch
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2006 21:09:20 -0000

In message: <e90md5$q6f$1@sea.gmane.org>
            othermark <atkin901@yahoo.com> writes:
: M. Warner Losh wrote:
: 
: > Please find enclosed an experimental patch.  It does two things.
: [...]
: > Anyway, please test these patches out and let me know if you have
: > problems.
: > 
: > Warner
: 
: (sorry about the wrapping here)
: 
: I tried to build it with a csup from this morning, and I get this
: compilation error:
: 
: 
: cc -c -O -pipe -march=pentiumpro -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -fformat-extensions -nostdinc -I-  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include
: opt_global.h -fno-common -finline-limit=8000 --param
: inline-unit-growth=100 --param
: large-function-growth=1000  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror  /usr/src/sys/dev/sio/sio_pci.c
: /usr/src/sys/dev/sio/sio_pci.c: In function `sio_pci_kludge_unit':
: /usr/src/sys/dev/sio/sio_pci.c:131: warning: implicit declaration of
: function `device_set_unit'
: /usr/src/sys/dev/sio/sio_pci.c:131: warning: nested extern declaration of
: `device_set_unit'
: *** Error code 1
: 
: Stop in /usr/obj/usr/src/sys/POGO.
: *** Error code 1
: 
: Stop in /usr/src.
: *** Error code 1
: 
: Stop in /usr/src.
: 
: A full find on /usr/src only reveals that one instance of usage that needs
: to be changed.

Doh!  I forgot to include that in my patch.  My mistake.  Comes from
doing too many things in that branch.

      http://people.freebsd.org/~imp/wire-unit.diff

Basically, delete the sio_pci_kludge_unit function, remove its
declaration and the one place it calls it.

Warner