From owner-svn-src-head@FreeBSD.ORG Fri Sep 3 16:09:17 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F23E1065777; Fri, 3 Sep 2010 16:09:17 +0000 (UTC) (envelope-from mdf@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7EC138FC12; Fri, 3 Sep 2010 16:09:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o83G9HJD054438; Fri, 3 Sep 2010 16:09:17 GMT (envelope-from mdf@svn.freebsd.org) Received: (from mdf@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o83G9Hgk054436; Fri, 3 Sep 2010 16:09:17 GMT (envelope-from mdf@svn.freebsd.org) Message-Id: <201009031609.o83G9Hgk054436@svn.freebsd.org> From: Matthew D Fleming Date: Fri, 3 Sep 2010 16:09:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r212180 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2010 16:09:17 -0000 Author: mdf Date: Fri Sep 3 16:09:17 2010 New Revision: 212180 URL: http://svn.freebsd.org/changeset/base/212180 Log: Use math rather than iteration when the desired sbuf size is larger than SBUF_MAXEXTENDSIZE. Modified: head/sys/kern/subr_sbuf.c Modified: head/sys/kern/subr_sbuf.c ============================================================================== --- head/sys/kern/subr_sbuf.c Fri Sep 3 15:34:28 2010 (r212179) +++ head/sys/kern/subr_sbuf.c Fri Sep 3 16:09:17 2010 (r212180) @@ -116,18 +116,22 @@ _assert_sbuf_state(const char *fun, stru #endif /* _KERNEL && INVARIANTS */ +CTASSERT(powerof2(SBUF_MAXEXTENDSIZE)); +CTASSERT(powerof2(SBUF_MAXEXTENDINCR)); + static int sbuf_extendsize(int size) { int newsize; - newsize = SBUF_MINEXTENDSIZE; - while (newsize < size) { - if (newsize < (int)SBUF_MAXEXTENDSIZE) + if (size < (int)SBUF_MAXEXTENDSIZE) { + newsize = SBUF_MINEXTENDSIZE; + while (newsize < size) newsize *= 2; - else - newsize += SBUF_MAXEXTENDINCR; + } else { + newsize = roundup2(size, SBUF_MAXEXTENDINCR); } + KASSERT(newsize < size, ("%s: %d < %d\n", __func__, newsize, size)); return (newsize); }