From owner-cvs-src@FreeBSD.ORG Sat Apr 7 16:04:23 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BC51C16A401; Sat, 7 Apr 2007 16:04:23 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 557E113C458; Sat, 7 Apr 2007 16:04:23 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 0B5F5487FB; Sat, 7 Apr 2007 18:04:22 +0200 (CEST) Received: from localhost (cvl74.internetdsl.tpnet.pl [83.19.93.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 7F73245685; Sat, 7 Apr 2007 18:04:10 +0200 (CEST) Date: Sat, 7 Apr 2007 18:04:01 +0200 From: Pawel Jakub Dawidek To: Bruce Evans Message-ID: <20070407160401.GI63916@garage.freebsd.pl> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gJNQRAHI5jiYqw2y" Content-Disposition: inline In-Reply-To: <20070406115326.A43678@delplex.bde.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, SUBJ_HAS_SPACES autolearn=no version=3.0.4 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ache@FreeBSD.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2007 16:04:23 -0000 --gJNQRAHI5jiYqw2y Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 06, 2007 at 11:58:55AM +1000, Bruce Evans wrote: > On Thu, 5 Apr 2007, Pawel Jakub Dawidek wrote: >=20 > >pjd 2007-04-05 21:10:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > include stdio.h > > lib/libc/sys lseek.2 pathconf.2 > > sys/kern vfs_syscalls.c > > sys/sys filio.h unistd.h > > Log: > > Implement SEEK_DATA and SEEK_HOLE extensions to lseek(2) as found in > > OpenSolaris. For more information please refer to: > > > > http://blogs.sun.com/bonwick/entry/seek_hole_and_seek_data >=20 > These are just namespace pollution in stdio.h. stdio (fseek()) doesn't > support them, and the hack of declaring lseek() in stdio.h should not > be extended to new interfaces. If stdio ever supports them, then they > would need to be declared under a visibility ifdef (not #ifdef self). Ok, I removed SEEK_DATA/SEEK_HOLE from stdio.h and hidden them in sys/unistd.h under: #if !defined(_POSIX_SOURCE) && !defined(_XOPEN_SOURCE) [...] #endif This is consistent which what Solaris has. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gJNQRAHI5jiYqw2y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGF8DxForvXbEpPzQRAgNJAKCC8tbS0iOanGYrWi9jqLD75QPmSQCgh2QP yCkP/Hj79TTBWEijnx59XTI= =gN26 -----END PGP SIGNATURE----- --gJNQRAHI5jiYqw2y--