Date: Wed, 30 Jan 2019 13:44:32 -0500 From: Ryan Stone <rysto32@gmail.com> To: Michael Tuexen <tuexen@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343525 - in head/sys/netinet: . tcp_stacks Message-ID: <CAFMmRNy1AOQ4tUjJqA1fCgY5JyZqUQiPj5rDBNLnnF8FJgKEQw@mail.gmail.com> In-Reply-To: <201901281245.x0SCjVpw048723@repo.freebsd.org> References: <201901281245.x0SCjVpw048723@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 28, 2019 at 7:46 AM Michael Tuexen <tuexen@freebsd.org> wrote: > > Author: tuexen > Date: Mon Jan 28 12:45:31 2019 > New Revision: 343525 > URL: https://svnweb.freebsd.org/changeset/base/343525 > > Log: > Fix the detection of ECN-setup SYN-ACK packets. > > RFC 3168 defines an ECN-setup SYN-ACK packet as on with the ECE flags > set and the CWR flags not set. The code was only checking if ECE flag > is set. This patch adds the check to verify that the CWR flags is not > set. Is this compatible with DCTCP? I seem to recall that it is possible for pure ACKs to be ECN marked in DCTCP.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNy1AOQ4tUjJqA1fCgY5JyZqUQiPj5rDBNLnnF8FJgKEQw>