From owner-svn-src-stable-8@FreeBSD.ORG Tue Jun 1 14:39:03 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D808A106566B; Tue, 1 Jun 2010 14:39:03 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id B0EAF8FC21; Tue, 1 Jun 2010 14:39:03 +0000 (UTC) Received: from lemongrass.sec.cl.cam.ac.uk (lemongrass.sec.cl.cam.ac.uk [128.232.18.47]) by cyrus.watson.org (Postfix) with ESMTPSA id C1E7846B8E; Tue, 1 Jun 2010 10:39:02 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: "Robert N. M. Watson" In-Reply-To: <2E4C7566-1F0E-4A44-8514-061FF1E129DE@gmail.com> Date: Tue, 1 Jun 2010 15:39:01 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <57DF5801-1685-4C69-9FD3-E56F5425E28C@FreeBSD.org> References: <201006011359.o51DxmSW050166@svn.freebsd.org> <2E4C7566-1F0E-4A44-8514-061FF1E129DE@gmail.com> To: Nikolay Denev X-Mailer: Apple Mail (2.1078) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r208692 - stable/8/sys/kern X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 14:39:04 -0000 On 1 Jun 2010, at 15:23, Nikolay Denev wrote: >> When close() is called on a connected socket pair, SO_ISCONNECTED = might be >> set but be cleared before the call to sodisconnect(). In this = case, >> ENOTCONN is returned: suppress this error rather than returning it = to >> userspace so that close() doesn't report an error improperly. >>=20 >> PR: kern/144061 >> Reported by: Matt Reimer , >> Nikolay Denev , >> Mikolaj Golub > I wonder, does this affect RELENG_7 ? (can't test at the moment, but = sys/kern/uipc_socket.c:soclose() looks similar) Yes, almost certainly -- if it doesn't manifest, it's just because of = timing differences, not because the bug isn't present. I'll look at = merging it to 7.x as well. Robert=