From owner-cvs-all Thu Feb 14 11:56:41 2002 Delivered-To: cvs-all@freebsd.org Received: from sydney.worldwide.lemis.com (adsl-64-173-25-69.dsl.sntc01.pacbell.net [64.173.25.69]) by hub.freebsd.org (Postfix) with ESMTP id 84C1837B41B; Thu, 14 Feb 2002 11:56:22 -0800 (PST) Received: (from grog@localhost) by sydney.worldwide.lemis.com (8.11.6/8.9.3) id g1EIw6Z02251; Thu, 14 Feb 2002 10:58:06 -0800 (PST) (envelope-from grog) Date: Thu, 14 Feb 2002 10:52:42 -0800 From: Greg Lehey To: Alfred Perlstein Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf GENERIC Message-ID: <20020214105242.A2226@sydney.worldwide.lemis.com> References: <200202131847.g1DIlp851160@freefall.freebsd.org> <20020213170750.B732@sydney.worldwide.lemis.com> <20020213172335.C63886@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020213172335.C63886@elvis.mu.org>; from alfred@FreeBSD.org on Wed, Feb 13, 2002 at 05:23:35PM -0800 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wednesday, 13 February 2002 at 17:23:35 -0800, Alfred Perlstein wrote: > * Greg Lehey [020213 17:08] wrote: >> On Wednesday, 13 February 2002 at 10:47:51 -0800, Alfred Perlstein wrote: >>> alfred 2002/02/13 10:47:51 PST >>> >>> Modified files: >>> sys/i386/conf GENERIC >>> Log: >>> Re-enable WITNESS for GENERIC. Since the 5.x branch is mostly about >>> SMP we'd like as much feedback as possible from users about possible >>> locking problems as early as possible. >> >> Why did you do that when obviously rwatson disagreed? The correct >> thing to do would have been to get a consensus first and give rwatson >> the opportunity to back it out. Note that we definitely don't have a >> consensus. >> >>> To negate most of the performance impact I've also enabled >>> WITNESS_SKIPSPIN. I've done this as we've been running WITNESS >>> over the spinlock code for a while without incident and it goes a >>> long way to making the performance problems of WITNESS much more >>> bearable. >> >> This might be a good compromise. But we need to agree first. > > This issue has been resolved, the WITNESS_SKIPSPIN stuff seems to have > made people a bit more comfortable about it. That's the technical issue. It doesn't address the issue of backing out other people's commits without consultation. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message